fix: Prevent AttributeError in Sentry cleanup and optimize gcov plugin - #774
Open
sentry[bot] wants to merge 1 commit into
Open
fix: Prevent AttributeError in Sentry cleanup and optimize gcov plugin#774sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue CLI-GN, which manifested as an
AttributeError: 'NoneType' object has no attribute 'get'during the 'Do Upload' transaction.The root cause was a combination of two factors:
gcovplugin, when enabled, would perform an exhaustive search for.gcnofiles across the entire project directory, including large vendor directories likenode_modules. This often led to extremely long runtimes and subsequentKeyboardInterruptsignals (e.g., due to CI timeouts)._before_sendhook, the code was attempting to call.get()on potentiallyNonevalues within the exception event structure. This would occur when aKeyboardInterrupt(or similar exception) was being processed, leading to theAttributeError.Changes implemented:
codecov_cli/plugins/gcov.pyto includenode_modules,.git, andvendorin the defaultfolders_to_ignorelist for theGcovPlugin. This prevents the plugin from scanning these large, irrelevant directories by default, significantly reducing scan times and the likelihood of timeouts._before_send: Updatedcodecov_cli/opentelemetry.pyto make the.get()calls within the_before_sendfunction more robust. It now explicitly handles cases where intermediate dictionary keys might haveNonevalues, preventing theAttributeErrorduring exception processing.Fixes CLI-GN
This PR was automatically generated by Sentry. You can adjust this setting at any time.