Repository navigation
docs: mark homelab-games-covers done - #209
Merged
Merged
Conversation
codedogapp/homelab#46 gave the laptop's games their covers, now that the user's Twitch app exists (decision 309), and IGDB has been checked live (decision 305).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged under the user's standing OK.
Brief
Goal. The plan says that the laptop's games have their covers. codedogapp/homelab#46, the
homelab-games-coversstep, gave them the user's Twitch app, which came the same day as decision 309.Scope.
docs/plan.md:games-exophaserow is "Done (feat(gateway): forward /api/games to the games service #188)", without the wait for a Twitch app.homelab-games-coversis done (codedogapp/homelab#46), andhomelab-gamessays its games came without covers until then.Out of scope. Code. The covers have worked since #186, on the Mac once the client ID is set, as
docs/setup.mdsays.Acceptance criteria.
mise run checkpasses.QA
BAKHYARD_E2E_PORT=8380 mise run checkon c68095e, withmainat c2ba98b merged in: green.docs/and the README for the wait finds no line left.games-settings, and the secret fromgames-secretsat/secrets, mode 0440. Its pod waits for the Secrets until the user'shomesecret sync.Review
No findings.