Repository navigation
Bump notebook-language-server-core and test the code action path - #19
Merged
Merged
Conversation
thomasjm
force-pushed
the
code-action-test-and-core-bump
branch
from
October 22, 2026 03:14
e5ce037 to
0e019f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up codedownio/notebook-language-server-core#6, which transforms
textDocument/selectionRange,semanticTokens/fulland/range, and the goto family. Those had no arms, so they reached the client in shadow coordinates and goto pointed at files in the shadow crate.Also adds
test/Test/CodeAction.hs, running the code action response path through the realStripDirective :> HeadTailTransformerrather than a stand-in. An edit rust-analyzer put on shadow line 8 comes back on notebook line 7, over bothtextDocument/codeActionandcodeAction/resolve, plus the cases that get dropped: a wrapper line, another file in the shadow crate, a file creation. A plain.rsfile takesidTransformerParamsand must not shift at all.That answers an off-by-one seen against 0.2.5.0 in codedown, where a quick fix landed on the line below. It isn't this repo and it isn't the transformer composition: 0.2.5.0's
textDocument/codeActionarm only filtered actions and never touched the edit, and it had nocodeAction/resolvearm. The untransform arrived in 0.2.6.0. Downstream just needs a newer version, which 0.2.7.0 is.Last commit switches the suite to
sandwich-discover, the way notebook-language-server-core does it, so a newtest/Test/*.hsexportingtestsis picked up without editingMain.hs. Modules undertest/Testrenamedspectoteststo match.