Repository navigation
Pick up the selection range chain fix, with a test through the real transformer - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
textDocument/selectionRangeanswered[]at every position, because every chain reaches thefn main() {the shadow document adds and the whole chain was required to map back. The fix is in notebook-language-server-core (#8 there); this moves the pin to it and releases 0.2.7.1.Adds
test/Test/SelectionRange.hs, covering both the request and response paths against the realStripDirective :> HeadTailTransformer— the bug only shows up once the chain meets a wrapper like this one's. Against the pre-fix core, the two response tests fail withBut got: [].