List open online activities that are already under way - #3659
Merged
Merged
Conversation
The calendar required a start date in the current month or later, so a long-running activity that began earlier was hidden even though it was still open to participants. Two such activities run into 2027. Gate the list on the end date instead, and treat an activity that has already begun as starting now so it appears under the current month rather than adding a past month to the filter. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
end_datealone, so activities that began earlier but have not finished are includedWhy
The month filter stopped at November 2026, which was correct: production has exactly one open-online activity starting in November and none after it.
Looking into it surfaced a real gap.
baseQuery()requiredstart_date >= firstOfMonth(), so any activity already under way was excluded even though the page describes itself as listing activities that welcome participants. Two open-online activities are currently in that position:Grouping them by their real start month would have added stray past months to the filter, so
effectiveStart()clamps an already-started activity to the current month.Test plan
php artisan test tests/Feature/OnlineEventsWorkflowTest.php— 15 passedMade with Cursor