Rename the featured activities page to Online Activities - #3660
Merged
Merged
Conversation
The page lists every upcoming open online activity rather than a curated selection, so "featured" no longer describes it. Move it to /online-activities and permanently redirect the old URL. For the menu label, reuse each locale's existing translation of "Online Activities" where one exists; twelve locales have none and keep their old wording until translators supply one. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/featured-activitiesto/online-activities, with a 301 redirect from the old URLfeatured_activitiestoonline_activitiesand update its three call sitesWhy
The page no longer shows a curated selection; it lists every upcoming open online activity, so "featured" was misleading.
Menu translations
menu.online_eventsalready holds a human translation of exactly this phrase, so rather than leaving 29 locales reading "Featured…", the label now reuses it. That covers 17 locales:bg, cs, da, de, el, fi, hr, it, lt, lv, pl, ro, sk, sl, sv, tr, ua— for example German shows Online-Aktivitäten and Italian Attività online.Needs translator input:
al, ba, es, et, fr, hu, me, mk, mt, nl, pt, rshave no existing translation of the phrase, so they keep their current wording (French still reads Activités en vedette, Spanish Actividades destacadas). Changing those would mean inventing translations, so I left them.Note on translation keys
The keys
menu.featured_activities,snippets.featured-activitiesandsnippets.no-featured-activitieskeep their names. Renaming them would touch 30 locale files plus a generated bundle for no user-visible benefit, and risks missing-key fallbacks.Test plan
php artisan test tests/Feature/OnlineEventsWorkflowTest.php— 16 passed/featured-activitiesreturns 301 to/online-activitiesdeanditrender the reused translationMade with Cursor