added summary doc for finance data - #2233
Open
J-C-L wants to merge 3 commits into
Open
Conversation
J-C-L
requested review from
Mephistic,
alexjball,
kiminkim724,
mertbagt,
mvictor55,
nesanders,
sashamaryl and
timblais
as code owners
September 2, 2026 01:20
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
J-C-L
force-pushed
the
finance-scrapper
branch
from
September 8, 2026 23:59
e3a6430 to
0783d5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a summary doc for finance scraper. Includes details about what OCPF codes we're including/exclusing and reasoning behind the decisions.
Also includes a minor code change, We currently display "number of contributors" on a legislator's finance page. But we really have # of distinct contributions. (ex: a person giving 5 separate times counts as 5, not 1.) Changing the display to "number of contributions:.
Checklist
firestore.indexes.json(Please do not only create indexes through the Firebase Web UI, even though the error messages may reccommend it - indexes created this way may be obliterated by subsequent deploys)