Skip to content

test: declare the throwing Parser filter closure as returning never - #10607

Merged
samsonasik merged 1 commit into
codeigniter4:developfrom
paulbalandan:parser-test-psalm
Oct 9, 2026
Merged

test: declare the throwing Parser filter closure as returning never#10607
samsonasik merged 1 commit into
codeigniter4:developfrom
paulbalandan:parser-test-psalm

Conversation

@paulbalandan

@paulbalandan paulbalandan commented Oct 9, 2026

Copy link
Copy Markdown
Member

Description
Quick fix on the Psalm failure.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@carson-codeigniter4 carson-codeigniter4 Bot added the testing Pull requests that changes tests only label Oct 9, 2026
@samsonasik

samsonasik commented Oct 9, 2026

Copy link
Copy Markdown
Member

Thank you @paulbalandan

@samsonasik
samsonasik merged commit 85917a7 into codeigniter4:develop Oct 9, 2026
26 of 27 checks passed
@paulbalandan
paulbalandan deleted the parser-test-psalm branch October 9, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes
@samsonasik samsonasik samsonasik approved these changes

Assignees

No one assigned

Labels

testing Pull requests that changes tests only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan @samsonasik @michalsn