Skip to content

test: avoid cached wrapper lookups in Bash 3.2 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quintesse merged 1 commit into from
Nov 3, 2026
Merged

test: avoid cached wrapper lookups in Bash 3.2 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Discovery, installation and uninstallation verification

CI wrapper lookup repair (2026-11-03): capture real `tar` and `sha256sum`
paths before isolating PATH, avoiding cached wrapper targets in Bash 3.2.
Syntax checks for `jvm` and `tests/install.sh`, all 35 offline installation
checks under installed Git Bash, and `git diff --check` passed. ShellCheck
was unavailable. Linux/macOS Bash 3.2 verification remains pending; no CI
runs, alternative shells or additional platform tests were started.

Install major-default verification (2026-11-03): `install -v` selects the
resolved JDK's major default in both entry points; `-d -v` selects the major
then global default, retaining a successful major update if the global update
Expand Down
8 changes: 6 additions & 2 deletions tests/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ export TEST_DEFAULT_GATE= TEST_DEFAULT_LINK=default TEST_REAL_LN
TEST_REAL_LN=$(command -v ln)
TEST_REAL_MV=$(command -v mv)
TEST_REAL_RM=$(command -v rm)
# Resolve wrapper targets before isolating PATH. Bash 3.2 can retain a cached
# wrapper path even with a temporary PATH assignment on `command -v`.
TEST_REAL_TAR=$(command -v tar)
TEST_REAL_SHA256SUM=$(command -v sha256sum)
for tool in uname ldd curl wget mv rm; do
printf '#!%s\n' "$BASH_BIN" > "$TOOLS/$tool"
case "$tool" in
Expand Down Expand Up @@ -1576,7 +1580,7 @@ mv "$TOOLS/sha256sum" "$TEMP/sha256sum"; mv "$TOOLS/openssl" "$TEMP/openssl"
before=$(count_downloads); run 1 install vendor-21; diagnostic 'install sha256sum'
[ "$(count_downloads)" = "$before" ] || fail 'missing verifier downloaded artifact'
# Exercise shasum-compatible and openssl adapters without a hidden runtime.
printf '#!%s\n[ "$1" = -a ] && shift 2\nexec "%s" "$@"\n' "$BASH_BIN" "$(PATH=$ORIGINAL_PATH command -v sha256sum)" > "$TOOLS/shasum"
printf '#!%s\n[ "$1" = -a ] && shift 2\nexec "%s" "$@"\n' "$BASH_BIN" "$TEST_REAL_SHA256SUM" > "$TOOLS/shasum"
PATH=$ORIGINAL_PATH chmod +x "$TOOLS/shasum"
run 0 install vendor-21
rm -f "$TOOLS/shasum"; mv "$TEMP/openssl" "$TOOLS/openssl"
Expand Down Expand Up @@ -1606,7 +1610,7 @@ TEST_ARCHIVE=$ROOT/tests/fixtures/archives/jdk.tar.gz
reset; index; row 21+1 vendor
mv "$TOOLS/tar" "$TEMP/tar"
run 1 install vendor-21; diagnostic 'required utility missing: tar'
printf '#!%s\ncase "$1" in -x*) exit 1 ;; esac\nexec "%s" "$@"\n' "$BASH_BIN" "$(PATH=$ORIGINAL_PATH command -v tar)" > "$TOOLS/tar"
printf '#!%s\ncase "$1" in -x*) exit 1 ;; esac\nexec "%s" "$@"\n' "$BASH_BIN" "$TEST_REAL_TAR" > "$TOOLS/tar"
PATH=$ORIGINAL_PATH chmod +x "$TOOLS/tar"
run 1 install vendor-21; diagnostic 'extraction failed'
mv "$TEMP/tar" "$TOOLS/tar"
Expand Down
Loading