Repository navigation
feat(api): send replies to a school's marketing email to its owner - #886
Merged
Merged
Conversation
A school's SendLit team is provisioned with the owner's email as Reply-To, next to the school's name as the sender, so replies don't land at the shared sending address. Docs: list the organization key scopes CourseLit needs (teams:manage, teams:keys, usage:read on top of the provisioning ones) and the one-time setup of the school-team organization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #881 (
feat/plan-limits).Each school's marketing email goes out from the organization's shared SendLit provider. The team's grant on that provider already carries the school's name as the From name; this adds the owner's email as Reply-To, so replies reach the school instead of the shared address.
What changes
sendlit-sender.tsbuilds the sender (school name, plus the owner's email when known). Both provisioning paths (the outbox job andensureSendLitTeam) use it.SENDLIT_ORGANIZATION_API_KEYneeds:organization:read,teams:provision,teams:read,teams:manage,teams:keys,usage:read. Withoutteams:manage, the plan quota can't be written to the team.plan-limits.mdsection 6 describes the marketing sender and the one-time setup of the school-team organization (subdomain sending address,autoGrantDefaultEspon,teamEspEnabledByDefaultoff).Depends on
SendLit's bootstrap key gaining those scopes: codelitdev/sendlit#202. QA's key needs them added by hand.
Tests
integration-provisioning.test.tschecks the reply-to sent at provisioning.