Repository navigation
fix(frontlit-pages): sync page and site schemas with FrontLit - #13
Merged
Merged
Conversation
The bundled schemas missed the pricing monthly/yearly switch, the header GitHub link and star count, and site.json agentInstructions (published as /llms.txt), so the checker rejected them and the references told agents they didn't exist.
canonicalSite only copied theme, header, footer and redirects, so check.mjs --fix silently deleted agentInstructions and any other new site setting. It now walks the schema's keys in order.
llms.txt starts with a single # title, so the second-H1 warning does not apply to site.json agentInstructions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
frontlit-pagesskill bundles copies of FrontLit'spage.v1.jsonandsite.v1.json. Those copies predate FrontLit's 24 Oct release (fb32112, "pricing period switch, header GitHub link, block icons") and the lateragentInstructionsfield. As a result:check.mjsrejects valid pages: it fails pages that usepricingSwitcher,priceYearly,githubRepoorshowGithubStarsas unknown settings, even though FrontLit's importer accepts them.blocks.mdsaid "There is no monthly/yearly switch". So agents working through Git couldn't build pages like sendlit.app or medialit.cloud, which were made in the visual builder with these features.Changes
scripts/schema/page.v1.jsonandsite.v1.jsonare now copied fromcodelitdev/frontlitmain(packages/page-builder/schema/).references/blocks.md: documents the pricing switch (pricingSwitcher,priceYearly,buttonActionYearly,monthlyPriceCaption,yearlyPriceCaption,defaultPeriod) and the headergithubRepo+showGithubStars.references/format.md: documentssite.jsonagentInstructions, which FrontLit serves at/llms.txt.check.mjs --fixno longer deletes site settings:canonicalSiteonly copiedtheme,header,footerandredirects, so--fixsilently removedagentInstructionsand any other new key. It now walks the schema's keys in order.agentInstructions:llms.txtstarts with one#title, so the second-H1 warning is skipped there.Found while building CourseLit's site from Git (codelitdev/courselit#882). That PR uses the pricing switch, the header star count and agentInstructions. FrontLit's "pages preview" PR check passes on it, which confirms the importer accepts them.
A follow-up should keep these copies from drifting again, for example with a CI job that diffs them against FrontLit's published schema.