Give App Shell and Document Layout regions the padding/background/border they never had - #23
Open
KolesnikovKirill wants to merge 1 commit into
Open
KolesnikovKirill wants to merge 1 commit into
KolesnikovKirill wants to merge 1 commit into
Conversation
…der they never had You pointed at a real screenshot: App Shell's sidebar and Document Layout's sidebar/aside had their content sitting flush against the edge, no visible panel around it at all. Checked why rather than guessing at a fix -- .cm-app-shell__sidebar, __aside, __content, __header, __subheader, and __footer, and the equivalent five regions in document-layout.css, had never had padding, and the sidebar/aside additionally never had a background or border. This predates the fidelity-restoration PR that just merged (#22): that PR fixed positioning, responsiveness, and sticky behavior for both files but left this specific gap, because I verified those changes by checking for console warnings and correct attribute/behavior state, not by looking hard enough at what was actually on screen. VueForge's fd79369 had exactly this chrome: .vf-sidebar-area / .vf-aside-area carried sidebarBackground/sidebarBorder and asidePaddingBlock/Inline, and .vf-content-area carried its own padding. Added the same shape here, using this package's own tokens rather than porting VueForge's token names: --cm-space-3 padding and --cm-color-background-surface on sidebar/aside/content, with border-inline-end on the sidebar and border-inline-start on the aside (--cm-color-border-subtle, matching every other border already in both files); --cm-space-2 --cm-space-3 padding on header/subheader/footer, matching the padding shorthand admin-layout.css and admin-shell.css already use for their own header/footer. Verified live against the real dev server, not by reading the diff: screenshotted both layouts after rebuilding, at the viewport width from your screenshot, and confirmed sidebar/aside now render as distinct panels with visible backgrounds and borders, with their slot content no longer touching the edges. npm run verify passes in full.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
You pointed at a real screenshot: App Shell's sidebar and Document Layout's sidebar/aside had their content sitting flush against the edge, no visible panel around it at all.
Checked why rather than guessing at a fix —
.cm-app-shell__sidebar,__aside,__content,__header,__subheader, and__footer, and the equivalent five regions indocument-layout.css, had never had padding, and the sidebar/aside additionally never had a background or border. This predates #22 (just merged): that PR fixed positioning, responsiveness, and sticky behavior for both files but left this specific gap, because I verified those changes by checking for console warnings and correct attribute/behavior state, not by looking hard enough at what was actually on screen.What changed
VueForge's
fd793696had exactly this chrome:.vf-sidebar-area/.vf-aside-areacarriedsidebarBackground/sidebarBorderandasidePaddingBlock/Inline, and.vf-content-areacarried its own padding. Added the same shape here, using this package's own tokens rather than porting VueForge's token names:--cm-space-3padding and--cm-color-background-surfaceon sidebar/aside/contentborder-inline-endon the sidebar andborder-inline-starton the aside (--cm-color-border-subtle, matching every other border already in both files)--cm-space-2 --cm-space-3padding on header/subheader/footer, matching the padding shorthandadmin-layout.cssandadmin-shell.cssalready use for their own header/footerVerified against the real thing
Screenshotted both layouts after rebuilding, at the viewport width from your screenshot, and confirmed sidebar/aside now render as distinct panels with visible backgrounds and borders, with their slot content no longer touching the edges.
Checks
npm run verifypasses in full.