feat(images): two-line boot-screen footer for the PR title#59
Merged
Conversation
📀 ISO build artifacts
↻ Updated for |
Split the boot-screen footer across up to two GRUB labels so a long PR title no longer overflows the screen width: line 1 (always): Coder Box - <short-sha>@<branch> line 2 (PR only): (PR #46: <title>) A non-PR build shows only line 1. box-turnkey.nix now exposes coderBox.bootLabelLine1 / bootLabelLine2 (replacing the single-line bootLabel), and base/iso.nix stacks the second label ~1 line-height below the first (emitted only when line 2 is non-empty).
phorcys420
changed the title
phorcys420
force-pushed
the
boot-menu-resolution
branch
from
aa34644 to
bf7526c
Compare
phorcys420
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The single-line boot-screen footer overflowed the screen width for PR-preview builds with a long title (e.g.
Coder Box - PR #47: fix(bootstrap): define CODER_ADMIN_* … (73fae985986d@admin-bootstrap-05…)ran off both edges).Change
Split the footer across up to two GRUB labels so the title has its own line:
box-turnkey.nixnow exposescoderBox.bootLabelLine1/bootLabelLine2(replacing the singlebootLabel);base/iso.nixstacks the second label ~1 line-height (font is 20px) below the first.The earlier aspect-ratio experiment (patching nixpkgs'
iso-image.nixto force a 4:3 GRUB resolution) was dropped — it was overkill and failed in CI — in favour of this.Validation
make fmt/make lint/make check(nix flake check --all-systems) — all clean / passed.Coder Box - 73fae985986d@admin-bootstrap-05and(PR #47: <full title>)).+28pxline gap is verified in the generated theme but not visually booted here.