fix: skip Pixel-flaky menu/spinner/icon/progress-bar motion, fix VSCodeParity Menu capture - #1085
Open
EhabY wants to merge 1 commit into
Open
fix: skip Pixel-flaky menu/spinner/icon/progress-bar motion, fix VSCodeParity Menu capture#1085EhabY wants to merge 1 commit into
EhabY wants to merge 1 commit into
Conversation
EhabY
force-pushed
the
ci/pixel-skip-menu-motion
branch
2 times, most recently
from
August 18, 2026 12:48
63dcec6 to
a12b734
Compare
EhabY
changed the title
…deParity Menu capture CSS animations are a likely source of flaky Pixel diffs: a capture can land mid-animation depending on timing, and infinite animations (spinner rotation, icon spin, indeterminate progress-bar travel) are never fast-forwarded by Playwright's animations:"disabled", so they freeze at whatever frame happens to be current. isPixel() (from @coder/pixel-storybook) is the documented hook for this but was unused anywhere in the repo; preview.ts now sets a data-pixel attribute from it so each component's CSS can zero out its animation only during captures. Also: - ci.yaml now reports the real PR head commit to Pixel (PIXEL_COMMIT) instead of GitHub's synthetic pull_request merge SHA, which changes on every run and was never seen on a prior build of the same PR. - The VSCodeParity "Menu" story was only capturing our DropdownMenu, not the VscodeContextMenu reference beside it. Switching to defaultOpen with an invisible trigger anchor renders both from the first paint, matching the reference's always-open show prop, and drops the unneeded visible "Menu" button from the comparison.
EhabY
force-pushed
the
ci/pixel-skip-menu-motion
branch
from
August 18, 2026 13:03
a12b734 to
b6f128a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.ui-menu,.ui-spinner,.ui-icon--spin, and the indeterminate.ui-progress-barall animate via CSS, which is a likely source of flaky Pixel diffs: a capture can land mid-animation depending on timing, and infinite animations (spinner rotation, icon spin, progress-bar travel) are never fast-forwarded by Playwright'sanimations: "disabled"-- they just freeze at whatever frame happens to be current.isPixel()from@coder/pixel-storybook/storyapiis the tool's documented hook for exactly this, but it was unused anywhere in this repo..storybook/preview.tsnow sets adata-pixelattribute on<html>whenisPixel()is true; each component's CSS zeroes out its animation only during captures. No effect outside Pixel (normal dev Storybook, production webview).ci.yamlnow setsPIXEL_COMMITto the real PR head SHA (github.event.pull_request.head.sha) instead of letting it default togithub.sha, which onpull_requestevents is a synthetic GitHub-generated merge commit that changes every run and was never seen on a prior build of the same PR.UI/VSCodeParityMenustory was only capturing ourDropdownMenu, missing theVscodeContextMenureference that's supposed to render beside it for comparison. Switched todefaultOpenwith an invisible trigger anchor so both render from the first paint, matching the reference's always-openshowprop, and dropped the unneeded visible "Menu" button from the comparison.