ci: fix release-gate exit code and rename status to Release Checklist - #510
Merged
Conversation
The gate posts its verdict as the Release PR Gate commit status, but the release-gate job always exited 0, so a failing gate still showed a green job check. Exit non-zero on a failure verdict (missing run-tests label, a failing required check, wrong base branch, or unticked release checkboxes) so the job matches the status. Deferrals and successes stay green.
imantsk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #509. Two changes to the release gate.
Exit code. The gate posts its verdict as a commit status, but the
release-gatejob always exited 0 — so on a failing verdict (a required check failed, wrong base branch, or unticked release-verification checkboxes) the status went red while the job check stayed green, reading as a false pass. The job now exits non-zero on a failure verdict (missingrun-tests, a failing required check, wrong base branch, or unticked checkboxes). Deferrals (required suites still running) and successes still exit 0 and stay green.Rename. The commit-status context is renamed from
Release PR GatetoRelease Checklist, along with the action name, step names, and comments. If a branch-protection required check references the old context name, update it toRelease Checklist.