Skip to content

fix: colour the tags help text where the field actually lives - #524

Merged
TallblokeUK merged 1 commit into
core-betafrom
fix/tags-help-contrast/core
Sep 3, 2026
Merged

fix: colour the tags help text where the field actually lives#524
TallblokeUK merged 1 commit into
core-betafrom
fix/tags-help-contrast/core

Conversation

@TallblokeUK

@TallblokeUK TallblokeUK commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #522: the help-text rule was nested under the sidebar block, but the tags field renders in the lower form area, so it never matched and the text stayed at 4.05:1. The rule now targets the tags container directly, which also outranks the component's injected single-class colour. Verified with axe on a wp-env site.

Summary by CodeRabbit

  • Style
    • Updated snippet tag form help text to use the standard muted text color.
    • Improved visual consistency for token-field help text in the snippet editor sidebar.

@TallblokeUK TallblokeUK added the run-tests Trigger automated tests label Sep 3, 2026
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 90954410-e79d-4112-b1f2-82c55b11a916

📥 Commits

Reviewing files that changed from the base of the PR and between efaeb56 and 5857dfb.

📒 Files selected for processing (2)
  • src/css/edit/_gpt.scss
  • src/css/edit/_sidebar.scss
💤 Files with no reviewable changes (1)
  • src/css/edit/_sidebar.scss

Included review availability: Your plan provides up to 8 included reviews per hour; 2 remain after this review.


Walkthrough

The snippet editor now applies the muted text color token to snippet tag help text. The sidebar no longer overrides the token-field help text color.

Changes

Snippet tag help text styling

Layer / File(s) Summary
Scoped token-field help text styling
src/css/edit/_gpt.scss, src/css/edit/_sidebar.scss
The snippet tags form applies var(--cs-color-text-muted) to token-field help text. The sidebar removes its custom color override.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 5857d

Snippet tag help text now receives the intended muted color within its rendered form container, without affecting unrelated token fields. The change is ready to merge.

Suggested reviewers: ramiy

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title uses the required conventional-commit format and clearly describes the tags help-text styling fix. It is 61 characters long.
Correctness And Security ✅ Passed No correctness or security defect was introduced. TagsEditor renders inside .snippet-tags-container in the lower form at src/js/components/EditMenu/SnippetForm/SnippetForm.tsx:215-219. The new s…
Ponytail: No Over-Engineering ✅ Passed PASS. The change uses one direct CSS selector in src/css/edit/_gpt.scss:116-118 and removes the ineffective nested rule from src/css/edit/_sidebar.scss:180-187. It adds no abstraction, dependency,…
Pr Hygiene ✅ Passed The commit title is a short conventional-commit summary: fix: colour the tags help text where the field actually lives. The PR description is present and states the selector change and its effect. I…
Scope Discipline ✅ Passed The PR addresses one concern: styling the tags help text in its actual container. The rule moves to .snippet-tags-container in src/css/edit/_gpt.scss:113-117, and the obsolete sidebar rule is remo…
Full details: Correctness And Security

Explanation

No correctness or security defect was introduced. TagsEditor renders inside .snippet-tags-container in the lower form at src/js/components/EditMenu/SnippetForm/SnippetForm.tsx:215-219. The new selector at src/css/edit/_gpt.scss:116-117 targets that container and uses the defined --cs-color-text-muted token. The stylesheet loads after the sidebar stylesheet, and the obsolete sidebar rule is removed at src/css/edit/_sidebar.scss:180-182.

Full details: Ponytail: No Over-Engineering

Explanation

PASS. The change uses one direct CSS selector in src/css/edit/_gpt.scss:116-118 and removes the ineffective nested rule from src/css/edit/_sidebar.scss:180-187. It adds no abstraction, dependency, or scaffolding. A simpler option is not needed because the direct selector is already the simplest fix.

Full details: Pr Hygiene

Explanation

The commit title is a short conventional-commit summary: fix: colour the tags help text where the field actually lives. The PR description is present and states the selector change and its effect. It contains no assistant attribution, private detail, or cross-repo disclosure. The issue reference and wp-env verification are not private details.

Full details: Scope Discipline

Explanation

The PR addresses one concern: styling the tags help text in its actual container. The rule moves to .snippet-tags-container in src/css/edit/_gpt.scss:113-117, and the obsolete sidebar rule is removed in src/css/edit/_sidebar.scss:180-182. No unrelated concern is present.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/tags-help-contrast/core
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/tags-help-contrast/core

Comment @coderabbitai help to get the list of available commands.

@TallblokeUK
TallblokeUK merged commit 372bcaa into core-beta Sep 3, 2026
31 of 34 checks passed
@TallblokeUK
TallblokeUK deleted the fix/tags-help-contrast/core branch September 3, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-tests Trigger automated tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant