fix: give the blueprint form items a visible keyboard focus indicator - #531
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. WalkthroughThe sidebar item focus state now displays a 2px inset accent outline while preserving existing hover and focus-visible styling. ChangesSidebar focus styling
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to Blueprint sidebar form items now show a visible keyboard focus outline while retaining existing hover styling. No merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
Full details: Pr HygieneExplanation The title is a short conventional-commit summary. The description is present and includes factual change details. The PR description also includes narrative review and merge history, which is not a factual change summary. It includes an AI-attribution block after the Verification section. No private or cross-repo disclosure was identified.
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
Summary
Follow-up to #530, which merged before this commit was pushed. The review thread on that PR was answered and resolved on the basis of this change, but the merge did not include it, so the issue it describes is still present on
core-beta.The blueprint form's list items removed the browser focus indicator with
outline: noneand relied on the background change alone to show focus. The unfocused fill#f6f7f7and the focused fill#c9e1f5differ by 1.26:1, well under the 3:1 minimum for a focus indicator, so keyboard focus was effectively invisible.outline: nonealso applied to:hover, where it did nothing.Hover and focus are now separated: hover keeps the fill and text colour, and
:focus-visibleadditionally draws a2pxoutline in--cs-color-accent-hover. That colour measures 6.80:1 against the focused fill and 8.54:1 against the surrounding list, both clearing the 3:1 minimum.outline-offset: -2pxdraws it inside the item, which sits flush against its neighbours.Verification
npm run build— compiles successfullynpm run lint:styles— cleanSummary by CodeRabbit