Check hidden files named explicitly on the command line - #4002
Open
ChrisJr404 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3822.
Passing a hidden file explicitly on the command line (for example
codespell ~/.bashrc) checked nothing, because the top-level loop skipped anything hidden unless--check-hiddenwas set. You had to already know about--check-hiddento check a file you had just named yourself, which is surprising.Now a hidden file named explicitly is always checked. Directories still honor
--check-hidden, so recursing into one (hidden or not) does not pull in hidden contents unexpectedly, which is what the issue asked for. An explicitly-named hidden directory is therefore still skipped without the flag.I updated
test_check_hiddento the new contract and added cases for an explicit hidden file (with and without--check-filenames) and for an explicit hidden directory still being skipped. I also added a note to the--check-hiddenhelp text so the behavior is discoverable. Fulltest_basic.pypasses, andruff check,ruff format --check, and mypy are clean.