Repository navigation
Prevent reporting failures and restore fatal error capture - #77
Conversation
neSpecc
left a comment
neSpecc
left a comment
There was a problem hiding this comment.
Fatal filter looks correct. The old && chain used the bitmask as a boolean, so any error_get_last() skipped the report. Shutdown tests cover the fatal, the warning and the duplicate exception.
handleException() still sets disableFatalErrorHandler for the rest of the process when it rethrows, and Catcher::sendException() always rethrows. After the caller catches that exception, later fatals in the same process are dropped. Clear the flag once the rethrow is caught outside, or skip it for a manual sendException().
| if ($event !== null) { | ||
| $this->send($event); | ||
| } | ||
| $this->captureSafely(function () use ($exception, $context): void { |
There was a problem hiding this comment.
isCapturing only wraps the send. On a nested handleException() captureSafely() returns immediately, then this method still clears previousExceptionHandler, sets disableFatalErrorHandler and throws.
That happens if beforeSend or the transport calls handleException() while a report is in progress: the nested event is dropped and fatal capture stays off for the rest of the process. sendEvent() already returns early in this situation. Same guard belongs at the top of handleException(), before the previous-handler tail. A test next to testBeforeSendCannotRecursivelyCapture would lock it.
| if ($event !== null) { | ||
| $this->send($event); | ||
| } | ||
| $this->captureSafely(function () use ($error): void { |
There was a problem hiding this comment.
E_ERROR skips finally, so a fatal in the middle of a report leaves isCapturing true. captureSafely() then returns and this fatal is never sent.
Shutdown does not resume the interrupted capture. Reset the flag at the start of handleFatal().
| $this->transport->send($event); | ||
| try { | ||
| $this->transport->send($event); | ||
| } catch (\Throwable $exception) { |
There was a problem hiding this comment.
Every Throwable from the transport is swallowed here, including a missing curl extension. sendMessage() and sendEvent() then return as if delivery worked.
Keeping the application running is right. Log the failure with error_log so a broken transport is visible.
Prevent transport failures and recursive reporting from interrupting the application.
Fix fatal-error filtering during shutdown and avoid duplicate reports.