fix: Retrieving routine revision with zero valued input or empty timeseries external ID in the configuration (#2470) - #2736
Merged
Conversation
… series external ID in the configuration (#2470) Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request resolves an issue where falsy values (such as 0 or an empty string) in SimulatorRoutineInput were incorrectly parsed as missing, resulting in an UnknownCogniteObject. The fix ensures that value and sourceExternalId are explicitly checked for non-None status, raises a ValueError if both are provided, and adds unit tests to verify this behavior. There are no review comments, so I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## pysdk-release-v7 #2736 +/- ##
====================================================
- Coverage 91.06% 91.05% -0.02%
====================================================
Files 192 192
Lines 26278 26282 +4
====================================================
Hits 23931 23931
- Misses 2347 2351 +4
🚀 New features to boost your workflow:
|
haakonvt
previously approved these changes
Aug 4, 2026
Contributor
|
@MortGron you need to pull in a few of the latest "test fixes commits" as well 😅 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Same as #2470
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.