Skip to content

fix(flaunch): exact Permit2 amountIn and short deadline - #1412

Closed
SashaMIT wants to merge 1 commit into
coinbase:mainfrom
SashaMIT:fix/flaunch-permit2-exact-allowance
Closed

fix(flaunch): exact Permit2 amountIn and short deadline#1412
SashaMIT wants to merge 1 commit into
coinbase:mainfrom
SashaMIT:fix/flaunch-permit2-exact-allowance

Conversation

@SashaMIT

@SashaMIT SashaMIT commented Aug 8, 2026

Copy link
Copy Markdown

Flaunch sellCoin was signing a Permit2 AllowanceTransfer for maxUint160 with a ~10-year expiration and sigDeadline whenever the current allowance was too low. That leaves the UniversalRouter with unbounded, long-lived rights to the memecoin after (or instead of) the intended sell.

This permits only the sell amountIn for 30 minutes. Same over-approval hygiene as the CDP exact Permit2 path in #1409, different provider and Permit2 surface (local typed data on Flaunch, not ERC-20 approve to Permit2). Sibling of #1409/#1410/#1411. Does not reopen those PRs' findings.

Test plan

  • pnpm exec jest --testPathPattern='flaunch/flaunchActionProvider' --coverage=false (20/20)
  • Regression: typed-data amount equals amountIn and is not maxUint160
  • Regression: expiration/sigDeadline are 30 minutes (not multi-year)
  • Regression: sufficient existing allowance skips signTypedData

Made with Cursor

Permit2 AllowanceTransfer on sellCoin used maxUint160 with a ~10-year
expiration/sigDeadline whenever allowance was low. Permit only this
sell's amountIn for 30 minutes so leftover UniversalRouter rights cannot
linger. Sibling hygiene to CDP exact Permit2 (coinbase#1409); distinct provider.
@SashaMIT
SashaMIT requested a review from murrlincoln as a code owner August 8, 2026 02:44
@cb-heimdall

Copy link
Copy Markdown

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@SashaMIT

Copy link
Copy Markdown
Author

Consolidating our open queue to reduce triage load. Closing this for now; the core set we are keeping open is #1392, #1404, #1405, #1409, #1421, #1423. Happy to reopen or refile this specific fix if a maintainer wants it.

@SashaMIT SashaMIT closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants