Skip to content

fix(fork): releases reach Claude's type fix again - #22

Merged
collissimo merged 2 commits into
collin/mainfrom
t3/fix-missing-release-checks
Oct 31, 2026
Merged

collissimo merged 2 commits into
collin/mainfrom
t3/fix-missing-release-checks

Conversation

@collissimo

Copy link
Copy Markdown
Owner

The latest fork release failed with typecheck failed without naming a file although tsc named the file. tsc prints src/x.ts(12,5): error TS... when its output goes to a file, and fork/resolve-merge.sh only understood the terminal form src/x.ts:12:5 - error. Claude's type fix never ran.

  • The script reads both forms and falls back to any path on an error TS line, so a new layout still reaches Claude.
  • Paths from packages (../../packages/...) resolve to the repository root; they would have tripped the "changed files it was not given" guard.
  • A conflict Claude settles with git rm no longer aborts the commit.
  • fork/resolve-merge.test.sh runs this path with stubbed vp and claude, and Fork check runs it. Four of its five cases fail on the old script.

Claude Opus 5.5 via Claude Code in T3 Code.

🤖 Generated with Claude Code

tsc prints src/x.ts(12,5): error TS... when its output goes to a file, but the release script only
understood the terminal form. Every type error of a merge therefore ended the run with "typecheck
failed without naming a file" before Claude saw it.

The script now reads both forms, falls back to any path on an error line, and resolves paths from
packages to the repository root. A conflict settled with git rm no longer breaks the commit.
Fork check runs the repair path against stubbed tools, because it otherwise only runs once a release
is already broken.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Oct 31, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@collissimo
collissimo merged commit 4cd149c into collin/main Oct 31, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant