Fix zipball/tarball name ignoring the name and version properties - #1
Closed
commi wants to merge 1 commit into
Closed
Fix zipball/tarball name ignoring the name and version properties#1commi wants to merge 1 commit into
commi wants to merge 1 commit into
Conversation
commi
force-pushed
the
fix-zipball-name
branch
3 times, most recently
from
August 21, 2026 13:01
220f081 to
b6610df
Compare
- problem: two package executions in one build write the same zip/tar file, and the name property has no effect on the archive name - cause: since c8f54bf the maven zip/tar name comes from build.finalName instead of the packager's name and version - solution: use name and version again, like the README documents and like the gradle plugin does The rename is still there, so the read-only finalName warning from c8f54bf does not come back. It now replaces an existing file, because File.renameTo does not do that on Windows. Signed-off-by: Till Seifert <me@till.seifert.name>
commi
force-pushed
the
fix-zipball-name
branch
from
August 21, 2026 13:05
b6610df to
57c27b9
Compare
Owner
Author
|
Superseded by javapackager#489. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since c8f54bf the maven zip/tar name comes from
build.finalNameinstead of the packager'snameandversion.So
namehas no effect on the archive name. With two package executions in one build, both write the same file. On Linux the second one overwrites the first. On Windows the rename fails and the archive keeps the name${build.finalName}.zip:The README documents
${name}-${version}-${platform}.zip, and the gradle plugin still creates that name. This PR updates the maven plugin so it behaves the same way.The rename is still there, so the read-only
finalNamewarning from c8f54bf does not come back. It now replaces an existing file, becauseFile.renameTodoes not do that on Windows. Otherwise a rebuild withoutcleankeeps the old archive.zipballNameandtarballNamestill work as before. For projects wherenameis not the artifactId, the default file name changes.