Skip to content

Fix thematic break after a link reference definition #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgm merged 1 commit into from
Sep 1, 2026
Merged

Fix thematic break after a link reference definition #628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions src/blocks.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -984,7 +984,6 @@ static void open_new_blocks(cmark_parser *parser, cmark_node **container,
bufsize_t matched = 0;
int lev = 0;
bool save_partially_consumed_tab;
bool has_content;
int save_offset;
int save_column;

Expand Down Expand Up @@ -1057,17 +1056,15 @@ static void open_new_blocks(cmark_parser *parser, cmark_node **container,
// text
} else if (!indented && cont_type == CMARK_NODE_PARAGRAPH &&
(lev =
scan_setext_heading_line(input, parser->first_nonspace))) {
// finalize paragraph, resolving reference links
has_content = resolve_reference_link_definitions(parser);

if (has_content) {

(*container)->type = (uint16_t)CMARK_NODE_HEADING;
(*container)->as.heading.level = lev;
(*container)->as.heading.setext = true;
S_advance_offset(parser, input, input->len - 1 - parser->offset, false);
}
scan_setext_heading_line(input, parser->first_nonspace)) &&
resolve_reference_link_definitions(parser)) {
// Setext underline only if paragraph content remains after resolving
// reference definitions; otherwise fall through so `---` can still
// be a thematic break.
(*container)->type = (uint16_t)CMARK_NODE_HEADING;
(*container)->as.heading.level = lev;
(*container)->as.heading.setext = true;
S_advance_offset(parser, input, input->len - 1 - parser->offset, false);
} else if (!indented &&
!(cont_type == CMARK_NODE_PARAGRAPH && !all_matched) &&
(parser->thematic_break_kill_pos <= parser->first_nonspace) &&
Expand Down
18 changes: 18 additions & 0 deletions test/regression.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,3 +331,21 @@ garbage on the same line must not be treated as a title.
<p>&quot;The title&quot; garbage
<a href="/bla">bla</a></p>
````````````````````````````````

Issue #619: `---` after a link reference definition is a thematic
break, not a paragraph.
```````````````````````````````` example
[f]:r
---
.
<hr />
````````````````````````````````

```````````````````````````````` example
[foo]: /url
---
[foo]
.
<hr />
<p><a href="/url">foo</a></p>
````````````````````````````````
Expand Down
Loading