Conversation
Contributor
|
AFAICT, this will rebuild the generated code on each build (if the tools could be found.) This is not what we want. Also see my comments in #580. |
|
@gemmaro have you tried to use |
Author
|
@AndersonTorres Yes I have. I think it is a good idea if it is more or less valuable for cmark maintainers as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, this addresses #580 by using CMake features to generate some support files.
The existing workflow doesn't change.
Makefiletasks forsrc/{scanners.c,case_fold.inc,entities.inc}are kept as is, and the added CMake custom commands are only invoked whenpython3,re2c, andclang-formatare installed.I added the
.clang-formatfile to let clang-format share the consistent behavior acrossMakefileand tool scripts.I referred the following resources:
add_custom_command(and its example usage),ifconditionals,find_program, (add_custom_targetthough I didn't use this time)Thank you,