Skip to content

Format with google-java-format (via spotless) - #444

Merged
robinst merged 2 commits into
mainfrom
google-java-format
Jul 30, 2026
Merged

Format with google-java-format (via spotless)#444
robinst merged 2 commits into
mainfrom
google-java-format

Conversation

@robinst

@robinst robinst commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Using AOSP style because:

Can check formatting with mvn spotless:check and run formatting with mvn spotless:apply. We could add the check to CI at some point, but yeah.

robinst added 2 commits July 29, 2026 17:18
Using AOSP style because:
- It's 4 spaces indentation (instead of 2 for the default). 4 spaces matches
  the current style, so reformatting isn't going to change all lines.
- It's also closer to OpenJDK's own style as commonmark-java is vendored there:
  https://github.com/openjdk/jdk/tree/master/src/jdk.internal.md/share/classes/jdk/internal/org/commonmark
Had to reflow some multi-line comments, but other than that all good.
@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.08811% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.76%. Comparing base (9477a93) to head (bb8c71f).

Files with missing lines Patch % Lines
...java/org/commonmark/internal/InlineParserImpl.java 85.00% 3 Missing and 3 partials ⚠️
...c/main/java/org/commonmark/internal/Delimiter.java 20.00% 4 Missing ⚠️
...main/java/org/commonmark/node/FencedCodeBlock.java 0.00% 4 Missing ⚠️
.../main/java/org/commonmark/parser/beta/Scanner.java 0.00% 4 Missing ⚠️
...commonmark/renderer/html/CoreHtmlNodeRenderer.java 42.85% 0 Missing and 4 partials ⚠️
...src/main/java/org/commonmark/node/OrderedList.java 0.00% 3 Missing ⚠️
...t/footnotes/internal/FootnoteHtmlNodeRenderer.java 91.30% 0 Missing and 2 partials ⚠️
.../src/main/java/org/commonmark/node/SourceSpan.java 66.66% 1 Missing and 1 partial ⚠️
.../commonmark/renderer/text/TextContentRenderer.java 33.33% 2 Missing ⚠️
...rk/ext/footnotes/internal/FootnoteBlockParser.java 85.71% 0 Missing and 1 partial ⚠️
... and 13 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #444      +/-   ##
============================================
- Coverage     94.78%   94.76%   -0.02%     
- Complexity      420      423       +3     
============================================
  Files           156      156              
  Lines          5174     5313     +139     
  Branches        757      788      +31     
============================================
+ Hits           4904     5035     +131     
- Misses          137      144       +7     
- Partials        133      134       +1     
Files with missing lines Coverage Δ
...org/commonmark/ext/autolink/AutolinkExtension.java 68.42% <ø> (ø)
...java/org/commonmark/ext/autolink/AutolinkType.java 100.00% <ø> (ø)
...k/ext/autolink/internal/AutolinkPostProcessor.java 92.18% <100.00%> (-0.24%) ⬇️
...g/commonmark/ext/footnotes/FootnoteDefinition.java 100.00% <ø> (ø)
...rg/commonmark/ext/footnotes/FootnoteReference.java 100.00% <ø> (ø)
...g/commonmark/ext/footnotes/FootnotesExtension.java 100.00% <100.00%> (ø)
...a/org/commonmark/ext/footnotes/InlineFootnote.java 100.00% <100.00%> (ø)
.../ext/footnotes/internal/FootnoteLinkProcessor.java 100.00% <100.00%> (ø)
...otnotes/internal/FootnoteMarkdownNodeRenderer.java 97.05% <ø> (ø)
...main/java/org/commonmark/ext/gfm/alerts/Alert.java 100.00% <ø> (ø)
... and 128 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robinst
robinst merged commit 78d4fac into main Jul 30, 2026
12 of 14 checks passed
@robinst
robinst deleted the google-java-format branch July 30, 2026 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant