Format with google-java-format (via spotless) - #444
Merged
Conversation
Using AOSP style because: - It's 4 spaces indentation (instead of 2 for the default). 4 spaces matches the current style, so reformatting isn't going to change all lines. - It's also closer to OpenJDK's own style as commonmark-java is vendored there: https://github.com/openjdk/jdk/tree/master/src/jdk.internal.md/share/classes/jdk/internal/org/commonmark
Had to reflow some multi-line comments, but other than that all good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using AOSP style because:
the current style, so reformatting isn't going to change all lines.
https://github.com/openjdk/jdk/tree/master/src/jdk.internal.md/share/classes/jdk/internal/org/commonmark
Can check formatting with
mvn spotless:checkand run formatting withmvn spotless:apply. We could add the check to CI at some point, but yeah.