Repository navigation
Honor opentelemetry_exclude_urls in the Litestar bootstrapper - #151
Merged
vrslev merged 1 commit intoOct 6, 2026
Merged
Conversation
This was referenced Sep 30, 2026
kek0vi4
reviewed
Oct 1, 2026
| from microbootstrap.config.faststream import FastStreamConfig | ||
| from microbootstrap.instruments.health_checks_instrument import HealthChecksInstrument | ||
| from microbootstrap.instruments.logging_instrument import LoggingInstrument | ||
| from microbootstrap.instruments.opentelemetry_instrument import ( |
Member
There was a problem hiding this comment.
Давай тут импортнем сразу instrument, чтобы импорт не разрастался
| def __init__(self, **kwargs: typing.Any) -> None: # noqa: ANN401 | ||
| # `broker` argument is positional-only | ||
| super().__init__(kwargs.pop("broker", None), **kwargs) | ||
| self.http_app: ASGIApp = super().__call__ |
Member
There was a problem hiding this comment.
Выглядит как-то оч странно, почему метод - это объект asgiapp?
| super().__init__(kwargs.pop("broker", None), **kwargs) | ||
| self.http_app: ASGIApp = super().__call__ | ||
|
|
||
| def add_http_middleware(self, build_middleware: typing.Callable[[ASGIApp], ASGIApp]) -> None: |
Member
There was a problem hiding this comment.
Поч функцию извне прокидываем? Разве нет какой-то функции, добаляющей миддлварь в фастстриме для веб приложения?
| def add_http_middleware(self, build_middleware: typing.Callable[[ASGIApp], ASGIApp]) -> None: | ||
| self.http_app = build_middleware(self.http_app) | ||
|
|
||
| async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None: |
Member
There was a problem hiding this comment.
Не оч нравится, что мы так переопределяем поведение объекта приложения, без этого никак не обойтись?
Comment on lines
+79
to
+88
| def build_faststream_route_details_from_scope( | ||
| scope: Scope, | ||
| routes: typing.Iterable[tuple[str, ASGIApp]], | ||
| ) -> tuple[str, dict[str, str]]: | ||
| method: typing.Final = str(scope.get("method", "HTTP")).strip() | ||
| path: typing.Final = scope.get("path") | ||
| # FastStream matches ASGI routes by exact path, unmatched paths get no `http.route` to keep its cardinality low | ||
| if path is None or all(path != route_path for route_path, _ in routes): | ||
| return method, {} | ||
| return build_span_name(method, path), {"http.route": path} |
Member
There was a problem hiding this comment.
Короче, мы тут как будто начинаем делать работу за фастстрим. Это не целевое решение. Давай закинем им в чат, что очень надо это поддержать. Пока предлагаю это не вливать и если очень надо сделать именно так, то это можно переопределить в конкретной репе (или сделать как у нас в репах)
Member
There was a problem hiding this comment.
Можешь даже сам пойти в фастстрим и запилить там ПР. Или зайти к Роме, есть там такой чувак, который за телеметрию отвечает
personage-hub
force-pushed
the
faststream-http-server-spans
branch
from
October 5, 2026 08:57
8493dc5 to
b0eb8b7
Compare
personage-hub
changed the title
personage-hub
force-pushed
the
faststream-http-server-spans
branch
from
October 5, 2026 10:10
b0eb8b7 to
5f8e27e
Compare
LitestarOpenTelemetryInstrumentationMiddleware read exclusions only from OTEL_PYTHON_LITESTAR_EXCLUDED_URLS, so the opentelemetry_exclude_urls setting was ignored for Litestar. Combine define_exclude_urls() with the env-based list (CombinedExcludeList) and build it once instead of per request. define_exclude_urls moves to BaseOpentelemetryInstrument and build_span_name to instruments/opentelemetry_instrument.py so other bootstrappers can reuse them without importing the Litestar module. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
personage-hub
force-pushed
the
faststream-http-server-spans
branch
from
October 6, 2026 08:35
5f8e27e to
7564f48
Compare
vrslev
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
LitestarOpenTelemetryInstrumentationMiddlewareread excluded urls only fromOTEL_PYTHON_LITESTAR_EXCLUDED_URLS(orOTEL_PYTHON_EXCLUDED_URLS), so theopentelemetry_exclude_urlssetting documented in the README had no effect for Litestar, andopentelemetry_generate_health_check_spans=Falsedid not suppress health-check spans either.Changes
LitestarOpenTelemetryInstrumentationMiddlewarecombinesdefine_exclude_urls()with the env-based list viaCombinedExcludeList, built once at middleware creation instead of per request.define_exclude_urlsmoves toBaseOpentelemetryInstrumentandbuild_span_nametoinstruments/opentelemetry_instrument.py, so other bootstrappers can reuse them without importing the Litestar module (thelitestarextra may be missing). Add OpenTelemetry instrument for FastMCP #152 relies on this.opentelemetry_exclude_urlsis["/metrics"], and both settings are described precisely.Scope note: an earlier revision of this PR also added
SERVERspans for FastStream ASGI routes. That part was dropped after review; the FastStream bootstrapper is untouched now.Breaking
opentelemetry_exclude_urlsused to be ignored for Litestar. Now the default/metricsexclusion applies, so/metricsstops producing spans, andopentelemetry_generate_health_check_spans=Falsesuppresses health-check spans (the default isTrue). This affects every Litestar user and should go into the release notes.Tests
opentelemetry_exclude_urls=["/internal"]suppresses spans without env vars; other routes still produceSERVERspans.just lint-ciandjust testpass (222 tests).🤖 Generated with Claude Code