Skip to content

AliasVault: TRUSTED_PROXIES accepts IPv4 only (0.31.2) - #2506

Open
jwklijnsma wants to merge 1 commit into
community-scripts:mainfrom
jwklijnsma:aliasvault-0.31.2
Open

jwklijnsma wants to merge 1 commit into
community-scripts:mainfrom
jwklijnsma:aliasvault-0.31.2

Conversation

@jwklijnsma

@jwklijnsma jwklijnsma commented Nov 6, 2026 •

Copy link
Copy Markdown

✍️ Description

Checked the AliasVault scripts against upstream 0.31.2: the install and update paths (core --web build, apps/web npm build, .NET 10 publish, nginx templates/entrypoint) are unchanged from 0.31.0, and the new server DB migration is applied by the Admin service on startup, so no script changes are needed. The only change is the reverse-proxy note, which now says TRUSTED_PROXIES takes IPv4 addresses, matching the 0.31.2 .env.example. Not re-run on a Proxmox host; verified by diffing the upstream 0.31.0 and 0.31.2 tags. Written with Claude Opus 5.5 (low reasoning effort).

🔗 Related PR / Issue

Link: #1827

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🏗️ arm64 Support (X in brackets)

  • arm64 supported - Tested and supported on arm64.
  • arm64 not tested - Assumed to work on arm64, but testing has not been done.
  • arm64 not supported - Confirmed upstream dependencies or binaries do not support arm64.

🖥️ Tested on (X in brackets)

  • Proxmox VE – Created on a Proxmox VE host and the app works.
  • Incus – Created on an Incus host and the app works.

Application containers run on both; tick what you actually tested. VMs and host tools are Proxmox only.


🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows CODE-AUDIT.md & CONTRIBUTING.md guidelines
  • Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
  • No hardcoded credentials
  • No Docker / Docker Compose – The application is installed bare-metal; Docker is not used.
  • No git pull – Updates use fetch_and_deploy_gh_release, fetch_and_deploy_codeberg_release, fetch_and_deploy_gl_release, or fetch_and_deploy_from_url instead of git pull.

📋 Additional Information (optional)


📦 Application Requirements (for new scripts)

⚠️ Do not remove this section.
It is used by automated PR validation checks.
If this PR is not a new script submission, leave the checkboxes unchecked.

Required for 🆕 New script submissions.
Pull requests that do not meet these requirements may be closed without review.

  • The application is at least 6 months old
  • The application is actively maintained
  • The application has 1,000+ GitHub stars
  • Official release tarballs are published
  • I understand that not all scripts will be accepted due to various reasons and criteria by the community-scripts ORG

🌐 Source

New version: https://github.com/aliasvault/aliasvault/releases/tag/0.31.2
Diff: aliasvault/aliasvault@0.31.0...0.31.2


🤖 AI Assistance (X in brackets)

Please describe to which degree, if any, an LLM was used in creating this pull request. Name the model(s) used and, if applicable, the reasoning/thinking effort level (e.g. "Claude Sonnet 4.5, high reasoning, used to draft the install script, then manually reviewed and tested" or "No LLM used"). This is informational, not a penalty — but scripts that are clearly AI-generated and not further revised by the author to match CODE-AUDIT.md / CONTRIBUTING.md may be closed without review.

Claude Opus 5.5, low reasoning, used to diff the upstream AliasVault 0.31.0 and 0.31.2 tags and make the one-word JSON note change, then reviewed by the author.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01SZrFpm2fJZaPL88EjuV8SH

@jwklijnsma
jwklijnsma requested a review from a team as a code owner November 6, 2026 21:02
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

✅ Requirements check passed. Thanks for fixing the description — the stale mark has been removed.

@github-actions github-actions Bot added json requirements missing PR description misses template items; closes after 7 days unless fixed or keep-open stale and removed requirements missing PR description misses template items; closes after 7 days unless fixed or keep-open stale labels Nov 6, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants