Repository navigation
core: load an app's own settings from its .vars file - #216
Merged
Merged
Conversation
One VAR_WHITELIST instead of three copies. VAR_RESERVED keys never come from a file. Updating app defaults keeps the app's settings and writes the file 0600. CI checks that every var_* the engine reads is classified.
Contributor
Try this branchThe engine and the scripts resolve independently, so a production script can COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/feat/app-vars-files \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"Swap Run a script from a fork as wellcurl -fsSL https://raw.githubusercontent.com/community-scripts/core/feat/app-vars-files/tools/run.sh |
bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
https://raw.githubusercontent.com/community-scripts/core/feat/app-vars-filesNote that Useful flags while testing
|
# Conflicts: # .github/workflows/verify-split-files.yml # ui/defaults.func
var_external_installer is a safety confirmation, so it joins VAR_RESERVED like the other per-run overrides; var_docker_lxcfs is a harmless app setting. The new test covers what default.vars and an app's own file each accept.
Saving app defaults took every exported var_* outside the two lists as the app's own setting, so a one-off var_appversion pin, var_full_verbose or var_unattended became permanent for the app. VAR_PER_RUN still loads from an app file written by hand, but a save no longer captures it.
MickLesk
marked this pull request as ready for review
November 6, 2026 16:56
michelroegl-brunner
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
One VAR_WHITELIST instead of three copies. VAR_RESERVED keys never come from a file. Updating app defaults keeps the app's settings and writes the file 0600. CI checks that every var_* the engine reads is classified.
🔗 Related Issue
Fixes #
✅ Prerequisites (X in brackets)
API.txtwas updated to match.🛠️ Type of Change (X in brackets)
README,docs/,CONTRIBUTING.md, or other docs.🤖 AI Assistance (X in brackets)