Repository navigation
core: detect GPUs by their PCI class, not by text anywhere in the line - #221
Merged
Merged
Conversation
lspci lines were matched against vga|3d|display as a whole, so an unnamed "Device 43d0" counted as a GPU (#217), as did an NVMe "SanDisk Ultra 3D", a Realtek "RTS5763DL" and a Xeon "Root Port 3d". hwaccel offered them for driver setup -- the AMD USB controller pulled the AMD stack including ROCm and, listed before the real card, set HWACCEL_VENDOR=amd -- and telemetry reported them as the GPU model. All four filters (hwaccel, sysinfo, the PVE and Incus backends) now match only the class field: VGA, XGA, 3D or Display controller. The pattern is inlined rather than shared because no single file is loaded in the container, on the host and by VM scripts alike.
Contributor
Try this branchThe engine and the scripts resolve independently, so a production script can COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/gpu-detect-pci-class \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"Swap This PR touches both backends. Worth running on a Proxmox VE and an Incus host. Run a script from a fork as wellcurl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/gpu-detect-pci-class/tools/run.sh |
bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
https://raw.githubusercontent.com/community-scripts/core/fix/gpu-detect-pci-classNote that Useful flags while testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
lspci lines were matched against vga|3d|display as a whole, so an unnamed "Device 43d0" counted as a GPU (#217), as did an NVMe "SanDisk Ultra 3D", a Realtek "RTS5763DL" and a Xeon "Root Port 3d". hwaccel offered them for driver setup -- the AMD USB controller pulled the AMD stack including ROCm and, listed before the real card, set HWACCEL_VENDOR=amd -- and telemetry reported them as the GPU model.
All four filters (hwaccel, sysinfo, the PVE and Incus backends) now match only the class field: VGA, XGA, 3D or Display controller. The pattern is inlined rather than shared because no single file is loaded in the container, on the host and by VM scripts alike.
🔗 Related Issue
Fixes #217
✅ Prerequisites (X in brackets)
API.txtwas updated to match.🛠️ Type of Change (X in brackets)
README,docs/,CONTRIBUTING.md, or other docs.🤖 AI Assistance (X in brackets)