Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inspired by AI driven work in PHPStan-src, I realized that the pcntl extension has a
pcntl_execfeature which allows to override the current process (instead of starting a sub-process and bridging signals, output back into the main process).while this does not make things faster in my testing, I can see it saves memory
when running my super-simplified
test.php:I guess perf numbers might be different in case xdebug-handler needs to bridge a lot of data between the subprocess and the parent process. but I was not yet able to proof that with examples.
env:
we are using this technique in phpstan-src 2.2.10 and 2.3.1 releases and it seems todo quite well. we do not yet have long term experience with it though.
this PR is mostly meant to get a discussion going and test this approach more widely and in more use-cases