chore: update fullsend shim workflow#3387
Conversation
Update the shim workflow to match the current template in the .fullsend config repo.
|
🤖 Finished Review · ✅ Success · Started 8:48 AM UTC · Completed 8:54 AM UTC |
Review — #3387Verdict: Request Changes SummaryThis PR, authored by the Findings1. 🔴 License header removal will break CI lint (
|
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| # lint-workflow-size: max-lines=280 |
There was a problem hiding this comment.
[high] lint-enforcement
Removing the Apache-2.0 license header will break make lint. The Makefile lint target runs addlicense -s -check across the repo and .github/workflows/fullsend.yaml is not in the LICENSE_IGNORE exclusion list. After merge, addlicense will report a missing header and CI will fail.
Suggested fix: Either retain the license header (and fix the upstream template to include it), or add -ignore .github/workflows/fullsend.yaml to LICENSE_IGNORE in the Makefile with a justification comment.
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| # lint-workflow-size: max-lines=280 |
There was a problem hiding this comment.
[medium] convention-violation
All 9 other workflow files in .github/workflows/ include the Apache-2.0 license header. Removing it from fullsend.yaml alone creates an inconsistency. If the upstream template intentionally omits the header, the resolution should be coordinated rather than a one-sided removal.
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This PR updates the fullsend shim workflow to match the current template in the
.fullsendconfig repo.The shim content has drifted from the template — this brings it back in sync.