Skip to content

chore: update fullsend shim workflow#3387

Open
fullsend-ai-fullsend[bot] wants to merge 1 commit into
mainfrom
fullsend/onboard
Open

chore: update fullsend shim workflow#3387
fullsend-ai-fullsend[bot] wants to merge 1 commit into
mainfrom
fullsend/onboard

Conversation

@fullsend-ai-fullsend

Copy link
Copy Markdown
Contributor

This PR updates the fullsend shim workflow to match the current template in the .fullsend config repo.

The shim content has drifted from the template — this brings it back in sync.

Update the shim workflow to match the current template
in the .fullsend config repo.
@fullsend-ai-review

fullsend-ai-review Bot commented Jul 7, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:48 AM UTC · Completed 8:54 AM UTC
Commit: 7c8ccca · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review — #3387

Verdict: Request Changes

Summary

This PR, authored by the fullsend-ai-fullsend bot, removes the 16-line Apache-2.0 license header from .github/workflows/fullsend.yaml to align it with the upstream template in the .fullsend config repo. However, the removal conflicts with the repository's enforced convention: every other workflow file carries the same header, and the addlicense lint gate in make lint will reject the file after merge.

Findings

1. 🔴 License header removal will break CI lint (high)

File: .github/workflows/fullsend.yaml:1
Category: lint-enforcement

The Makefile's lint target runs addlicense -s -check across the entire repo. The LICENSE_IGNORE variable excludes specific paths (dist/cli-reference/*.yaml, acceptance/examples/**/*.yaml, configs/*/*.yaml, .tekton/*.yaml, .ec/**, etc.) but does not exclude .github/workflows/fullsend.yaml. After this merge, make lint will exit non-zero due to the missing license header, blocking CI.

Remediation: Either retain the license header (and fix the upstream template to include it), or update the LICENSE_IGNORE variable in the Makefile to add -ignore '.github/workflows/fullsend.yaml' — with a comment explaining why this file is exempt.

2. 🟡 Convention violation — sole workflow without license header (medium)

File: .github/workflows/fullsend.yaml:1
Category: convention-violation

All 9 other workflow files in .github/workflows/ (auto-merge.yaml, checks-codecov.yaml, codeql.yaml, label-pr-size.yaml, lint.yaml, release.yaml, update-go-containerregistry.yaml, website.yaml, scorecard.yml) include the Apache-2.0 license header. Removing it from fullsend.yaml alone creates an inconsistency. If the upstream template intentionally omits the header, the resolution should be coordinated: either exempt this file from addlicense with justification, or update the template to include the header.

Security

No security concerns. The diff is purely comment removal — no permissions, triggers, secrets, steps, or functional YAML are modified.

Documentation

No documentation impact. No behavioral changes, renamed identifiers, or new public symbols.


Labels: PR modifies a GitHub Actions workflow file.

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

#
# SPDX-License-Identifier: Apache-2.0

# lint-workflow-size: max-lines=280

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[high] lint-enforcement

Removing the Apache-2.0 license header will break make lint. The Makefile lint target runs addlicense -s -check across the repo and .github/workflows/fullsend.yaml is not in the LICENSE_IGNORE exclusion list. After merge, addlicense will report a missing header and CI will fail.

Suggested fix: Either retain the license header (and fix the upstream template to include it), or add -ignore .github/workflows/fullsend.yaml to LICENSE_IGNORE in the Makefile with a justification comment.

#
# SPDX-License-Identifier: Apache-2.0

# lint-workflow-size: max-lines=280

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] convention-violation

All 9 other workflow files in .github/workflows/ include the Apache-2.0 license header. Removing it from fullsend.yaml alone creates an inconsistency. If the upstream template intentionally omits the header, the resolution should be coordinated rather than a one-sided removal.

@fullsend-ai-review fullsend-ai-review Bot added the github_actions Pull requests that update GitHub Actions code label Jul 7, 2026
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
acceptance 53.44% <ø> (+<0.01%) ⬆️
generative 17.37% <ø> (ø)
integration 28.67% <ø> (ø)
unit 71.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants