fix(runc-shim): support realtime signals for exec processes - #491
Open
immanuwell wants to merge 1 commit into
Open
fix(runc-shim): support realtime signals for exec processes#491immanuwell wants to merge 1 commit into
immanuwell wants to merge 1 commit into
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
Member
|
Needs import cleanup: |
There was a problem hiding this comment.
Pull request overview
Updates exec-process signaling to support Linux realtime signals.
Changes:
- Replaces
nix::Signalconversion with rawlibc::kill. - Adds a realtime-signal regression test.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+848
to
+852
| use std::{ | ||
| os::unix::process::ExitStatusExt, | ||
| path::Path, | ||
| process::{Command as StdCommand, ExitStatus}, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exec kills panic for Linux realtime signals because
nix::Signalrejects them.Use
libc::killso the kernel validates raw signal values.Also, this matches the Go runc shim
Repro:
34 is
SIGRTMINon x86_64 Linux.Added a regression test too