Repository navigation
fix: hardcoded test secrets and qs/follow-redirects vulnerabilities (Snyk) - v1.5.4 - #269
Merged
Merged
Conversation
Back merge
…velopment chore: back-merge main into development
Per-run generated values for credential-shaped test inputs, qs 6.16.1, follow-redirects 1.16.2 and v1.5.4. Refresh the package-lock checksum and add checksum-pinned Talisman entries for four flagged test files. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
cs-raj
previously approved these changes
Oct 30, 2026
cs-raj
previously approved these changes
Nov 2, 2026
Bump qs to 6.17.1, axios to ^1.21.0 and tslib to ^2.9.1, as requested in review. Lock file refreshed (follow-redirects stays at 1.16.2) and the .talismanrc checksum for package-lock.json updated to match. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
Coverage report
Test suite run success163 tests passing in 8 suites. Report generated by 🧪jest coverage report action from 0373a2c |
Coverage report
Test suite run success163 tests passing in 8 suites. Report generated by 🧪jest coverage report action from 0373a2c |
cs-raj
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the Snyk findings in this repo: DX-22032 to DX-22041 (hardcoded test secrets/passwords), plus the unticketed
qsandfollow-redirectsvulnerabilities (v1.5.4).apiKeyvalues are the ALL_CAPS placeholderYOUR_API_KEY;accessTokenandpassworduse per-run generated values from a newtest/utils/test-secrets.ts(Snyk treats those property names as credential sinks, and the tests compare against the value). Removeddeepcode ignorecomments in the tests.qs6.16.0 → 6.16.1 (exact pin),follow-redirects→ 1.16.2 (via axios). Patch-level only..talismanrc: refreshed the pinned checksum forpackage-lock.json(it changes with the dependency bump, as in previous bumps), and added checksum-pinned entries for four test files (test/request.spec.ts,test/utils/mocks.ts,test/contentstack-error.spec.ts,test/utils/test-secrets.ts). Talisman flags them at low severity by keyword (password: TEST_PASSWORD,apiKey: 'YOUR_API_KEY') even though the values are generated or placeholders; this is the same mechanism the repo already uses for other test files. Please review these entries.Verification
snyk code test: 10 → 0.snyk test: 3 → 0.🤖 Generated with Claude Code