feat: migrate HTTP layer from Newtonsoft.Json to System.Text.Json#41
Draft
OMpawar-21 wants to merge 1 commit into
Draft
feat: migrate HTTP layer from Newtonsoft.Json to System.Text.Json#41OMpawar-21 wants to merge 1 commit into
OMpawar-21 wants to merge 1 commit into
Conversation
Replace all Newtonsoft usage across the HTTP abstraction layer as part of the STJ migration. Renames OpenJObjectResponse() to OpenJsonObjectResponse() returning System.Text.Json.Nodes.JsonObject, swaps JsonSerializer (Newtonsoft) for JsonSerializerOptions throughout the request/response pipeline, and replaces JsonConvert.SerializeObject with JsonSerializer.Serialize for query param building. Files changed: - CMA/Http/IResponse.cs - CMA/Http/ContentstackResponse.cs - CMA/HTTPRequestHandler.cs - CMA/Http/ContentstackHttpRequest.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Newtonsoft.Jsonusage in the HTTP abstraction layer withSystem.Text.JsonOpenJObjectResponse()→OpenJsonObjectResponse()returningSystem.Text.Json.Nodes.JsonObjectNewtonsoft.Json.JsonSerializerwithSystem.Text.Json.JsonSerializerOptionsacross the request/response pipelineJsonConvert.SerializeObject()withJsonSerializer.Serialize()for query parameter building