fix(deps): resolve 6 Snyk vulnerabilities via npm overrides (+Claude) - #219
fix(deps): resolve 6 Snyk vulnerabilities via npm overrides (+Claude)#219dhruv-parekh-cs wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
There was a problem hiding this comment.
Pull request overview
Updates dependency resolution to remediate six transitive Snyk findings in this Node.js CLI repo by adding/adjusting npm overrides, regenerating the lockfile accordingly, and updating the Talisman allowlist checksum for the modified lockfile.
Changes:
- Added
overridesentries to force patched versions offast-uri,js-yaml, andbrace-expansion(scoped byminimatchmajor). - Updated
package-lock.jsonto reflect the new override-driven dependency graph. - Updated
.talismanrcchecksum forpackage-lock.jsonso pre-commit secret scanning does not block the changed lockfile.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Adds new overrides pins/scoped overrides to remediate transitive vulnerabilities. |
| package-lock.json | Lockfile refreshed to reflect overridden versions (e.g., fast-uri, js-yaml, brace-expansion). |
| .talismanrc | Updates stored checksum for the modified package-lock.json. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "tmp": "^0.2.4" | ||
| "tmp": "^0.2.4", | ||
| "fast-uri": "^3.1.5", | ||
| "js-yaml": "^4.3.1", |
Automated Snyk remediation pass (
/snyk-fix, run date 12-Aug-2026). Surface in scope: Node.js. Public repo — Conventional Commits used.Summary
All six findings are transitive (nothing vulnerable is declared directly), so each is pinned through the existing
overridesblock. Caret ranges throughout, so future compatible patches aren't blocked.brace-expansion2.1.2@oclif/core > ejs > jake > filelist > minimatch@5.1.9 > brace-expansion"minimatch@5": { "brace-expansion": "^2.1.4" }brace-expansion5.0.7@oclif/core > minimatch@10.2.5 > brace-expansion"minimatch@10": { "brace-expansion": "^5.0.9" }brace-expansion5.0.7@oclif/core > minimatch@10.2.5 > brace-expansionminimatch@10entry (^5.0.9satisfies both advisories)fast-uri3.1.3@contentstack/cli-utilities > conf > ajv@8.20.0 > fast-uri"fast-uri": "^3.1.5"fast-uri3.1.3^3.1.5satisfies both advisories)js-yaml4.3.0@contentstack/cli-utilities > js-yaml"js-yaml": "^4.3.1"Why
brace-expansionis path-scoped rather than a single top-level overrideThe tree holds two
brace-expansionmajors at once —2.1.2underminimatch@5and5.0.7underminimatch@10— needing≥2.1.4and≥5.0.9respectively. A single top-level"brace-expansion": "^5.0.9"would forceminimatch@5's copy across a major boundary. The two path-scoped entries patch each in place instead, matching the"minimatch@3": { … }selector style already used elsewhere in this repo's overrides.Application-code changes
None.
package.json/package-lock.jsonplus one.talismanrcline — see below..talismanrcchange (please review)The Talisman pre-commit hook already allowlists
package-lock.jsonby content checksum. The lockfile content changed, so its recorded checksum went stale and blocked the commit (Talisman flags npmintegrityfields — base64 SHA-512 digests — as "base64 encoded texts"). Only that one checksum was updated to the value Talisman itself reported; no new file was allowlisted and no scan was bypassed.Validation
npm install— pass, no peer-dependency warningsnpm test— passnpm run build— passsnyk test --all-projectsre-scan — clean, 0 issues remaining (the repo's own pre-commit Snyk gate also reported "Tested 463 dependencies for known issues, no vulnerable paths found")Needs human review
None for this repo.
🤖 Generated with Claude Code