Skip to content

fix(deps): retire obsolete qs and follow-redirects overrides (+Claude) #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dhruv-parekh-cs wants to merge 1 commit into from
Closed

fix(deps): retire obsolete qs and follow-redirects overrides (+Claude) #276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,6 @@
"prepare": "husky"
},
"overrides": {
"qs": "~6.16.2",

@dhruv-parekh-cs dhruv-parekh-cs Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Medium] These two overrides aren't obsolete: they are the only manifest floor above the vulnerable versions.

In the resolved tree, express and body-parser declare qs ~6.16.0 (and @contentstack/management declares qs ^6.16.0), so 6.16.0 and 6.16.1 (SNYK-JS-QS-20943482 / SNYK-JS-QS-21755395) are still in range. axios declares follow-redirects ^1.16.0, so 1.16.1 (GHSA-mrwp-f3q8-3g9p) is also still in range. Today only package-lock.json keeps qs@6.16.2 / follow-redirects@1.16.2. A lockfile regeneration, a lockfile-conflict re-resolve, or an install from a mirror or cache that holds the older patch can silently put a vulnerable version back, with no override to stop it.

Suggested fix: keep both overrides. Retirement should wait until each parent's own declared range excludes the vulnerable versions, not just until the current resolution happens to land above them. That would make this PR a no-op, so closing it is reasonable.

"follow-redirects": "^1.16.2",
"tty-table": {
"csv": "^6.6.4"
},
Expand Down
Loading