Repository navigation
fix(core): drop the -y short flag from --yes - #280
Merged
Merged
Conversation
--yes now has no short form, so -y is a nonexistent flag (exit 2) on every confirm-gated command: projects:delete, env:delete, env:update, variables:unset, secrets:set, secrets:unset, deployments:rollback and deployments:cancel. They all take --yes from the one catalog entry. V1 never had --yes, so no V1 script relies on -y. A secret glued onto -y (secrets:set -y<value>) is still refused with exit 2 without echoing the value, now as an unknown flag. README regenerated with oclif readme. .talismanrc: refresh the checksums of README.md and catalog.test.ts, which this change edits, and of 14 files v2-dev changed without updating theirs (package.json, failure.test.ts, launch-command.test.ts, search-list.test.ts, and the secrets command, resource and test files). search-list.test.ts moves from a per-line allowed_pattern to a per-file checksum. Without this the Talisman pre-push hook fails for any branch pushed fresh off v2-dev, because it scans against origin/main. #claude_code# 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
🔒 Security Scan Results
⏱️ SLA Breach Summary
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
✅ BUILD PASSED - All security checks passed |
chhavi-mandowara-cstk
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CL-7174, a follow-up to #277's short-flag policy.
What
--yesno longer has a short form.-ynow fails at parse time withNonexistent flag: -y(exit 2) instead of skipping the confirmation.projects:delete,env:delete,env:update,variables:unset,secrets:set,secrets:unset,deployments:rollbackanddeployments:cancel.--yes, so no V1 script breaks. A V2 beta script that uses-yhas to switch to--yes.oclif readme. Its only changes are-y, --yes→--yesand[-y]→[--yes]..talismanrcrefreshes the checksums of the two files this change edits (README.md,src/core/catalog.test.ts). It also refreshes 14 that v2-dev changed without updating theirs:package.json,src/core/failure.test.ts,src/core/launch-command.test.ts,src/core/search-list.test.ts,src/secrets/secret.rules.ts,src/secrets/secret.rules.test.ts,src/secrets/secret.value.ts,src/secrets/secret.presenter.ts,src/secrets/secret.presenter.test.ts,src/secrets/types.ts,src/commands/launch/secrets/list.ts,src/commands/launch/secrets/set.test.ts,src/commands/launch/secrets/unset.test.tsandtest/integration/secrets-list.test.ts.search-list.test.tsmoves from a per-lineallowed_patternsentry to a per-file checksum. Without the refresh, the Talisman pre-push hook fails for any branch pushed fresh off v2-dev, because a new remote branch is scanned againstorigin/main.Tests
src/core/catalog.test.tsadds three cases.--yeshas no short flag,--yesstill parses astrue, and-yis rejected. Two of them failed before the change.secrets:setS8 case still passes. A secret glued onto-y(-y<value>) exits 2 without echoing the value, now as an unknown flag.e025edc(csdx 2.x):npm run lintand a from-cleannpm run buildsucceed, andnpm testpasses with exit 0 (193 suites, 3822 tests).ggshield secret scanfound no secrets, Talisman passes overmain..HEAD(the range the hook uses for a new branch), and trufflehog found 0 verified and 0 unverified secrets.--no-verifybecause the pre-commit hook'ssnyk test --fail-on=allfails on 5 dependency vulnerabilities already on v2-dev since feat(deps): run Launch CLI V2 on csdx 2.x with cli-utilities 2 and cli-command 2 #279 (high:follow-redirects@1.16.1,picomatch@4.0.5; medium:minimatch@5.1.9,adm-zip@0.6.1,deepmerge@4.3.1). This PR changes no dependencies, so those need their own fix.#claude_code#
🤖 Generated with Claude Code