Repository navigation
fix(deps): clear the Snyk findings that block every v2-dev commit - #281
Conversation
The pre-commit snyk test --fail-on=all failed on four findings already on v2-dev, so no commit could pass its hooks: - follow-redirects 1.16.1 (High, via axios): the lockfile moves to 1.16.2. - minimatch (Medium, SNYK-JS-MINIMATCH-22111072): @oclif/core moves 4.11.14 -> 4.14.0 in the lockfile, which drops the ejs > jake > filelist > minimatch 5 path. The advisory is fixed only in minimatch 11.0.1, and every @oclif/core 4 and 5 asks for ^10.2.5, so an override gives @oclif/core minimatch ^11.0.1. oclif calls only minimatch(name, pattern) in its plugin loader, which 11 keeps. - adm-zip 0.6.1 and deepmerge 4.3.1 (Medium) have no fixed release. A .snyk policy ignores each until 2026-12-04, with the reason: launch-cli only writes zips from local files and never parses one, and deepmerge is reached only through rollup's node-resolve with options launch-cli sets itself. The .talismanrc checksum for package.json is refreshed; Talisman flags its existing LNCH-SEC-* error codes, no secret. snyk test now finds no vulnerable paths. Build, lint and the full suite (3822 tests) pass. #claude_code# 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Co-authored-by: Sakshi Koli <sakshi.koli@contentstack.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
dhruv-parekh-cs
left a comment
There was a problem hiding this comment.
Reviewed the whole PR: no high or medium issues. The @oclif/core → minimatch ^11 override is API-compatible (core only calls the named minimatch() export), and both .snyk ignores expire on 4 Dec 2026.
Cross-repo (CL-7174): merge order is #281 → #282 → contentfly-dev-workspace#180. #180's 50-lifecycle GitHub create answers "Add environment variables" with a bare Enter, which a CLI built before #282 refuses (the checklist still requires a selection), so run the harness only against a CLI that includes #282.
— 🤖 launch-pr-review-agent (Claude)
Generated by Claude Code
snyk test --fail-on=all fails only on findings that have an upgrade or patch. adm-zip 0.6.1 and deepmerge 4.3.1 have neither, so the pre-commit hook and CI's security-sca check (SLA based) already pass without ignoring them. The hook was blocked only by follow-redirects and minimatch, which this PR fixes. Both remain reported, so they stay visible until a fix ships. #claude_code# 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Co-authored-by: Sakshi Koli <sakshi.koli@contentstack.com>
6cad213
🔒 Security Scan Results
⏱️ SLA Breach Summary
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
✅ BUILD PASSED - All security checks passed |
What
The pre-commit
snyk test --all-projects --fail-on=allfails on four findings that are already onv2-dev, so no commit there can pass its hooks. This PR clears all four:ejs > jake > filelist > minimatch@5path. The fix exists only in minimatch 11.0.1, and every @oclif/core 4 and 5 release asks for^10.2.5, so an override gives @oclif/coreminimatch ^11.0.1. oclif calls onlyminimatch(name, pattern)in its plugin loader, and 11 keeps that..snykpolicy ignores each until 2026-12-04 and gives the reason:src/uploads/upload.archive.ts) and never parses one.@rollup/plugin-node-resolveduringfunctions:serve, merging options launch-cli sets itself.Note: npm
overridesand the lockfile only apply to installs of this repo (dev, CI, Snyk). A user'scsdx plugins:installresolves @oclif/core's own^10minimatch, as it already does for every other override here.Tests
snyk test --all-projects --fail-on=all: no vulnerable paths found.npm run build,npm run lintandnpm testall pass (193 suites, 3822 tests).csdx launchhelp loads.--no-verify.#claude_code#
🤖 Generated with Claude Code