You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(visual-builder): edit entry tags from the canvas toolbar - #670
Entry tags are now a field type the canvas can edit in the popup.
FieldDataType.TAGS ("tags") is added, and getFieldType returns it for data_type: "tags".
TAGS is allowed for modal editing, fieldIcons has tags: EditIcon, and FieldTypeIconsMap has a tags icon for the label and the cursor (the icon is the Venus tag icon, resized to 24 by 24).
FieldToolbar treats tags as one whole value, like a multiple Select or Taxonomy: clicking the tags container or one chip shows the Edit button, and Edit posts OPEN_FIELD_EDIT_MODAL for tags without the chip index.
Disabling is unchanged: a tags restriction, missing entry permission or a locked workflow stage still goes through isFieldDisabled. The OPEN_FIELD_EDIT_MODAL payload shape is unchanged.
Test evidence
npm run lint: 0 errors (existing warnings only)
npx vitest run --changed origin/develop_v4: 80 files, 553 tests passed
npm run build: passed
npx prettier --check on the changed files: only FieldToolbar.tsx warns, and it already did before this change, so it is not reformatted here to keep the diff small.
Criterion to test map
Criterion
Test
getFieldType returns TAGS for data_type: "tags"
getFieldType.test.ts: "should return tags if data_type is tags"
Container click shows an enabled Edit button and posts tags
click/fields/tags.test.tsx: "container click posts the whole tags field"
Chip click posts tags without the index
click/fields/tags.test.tsx: "chip click posts tags without the index"
Restricted field disables Edit
click/fields/tags.test.tsx: "restricted tags field disables the edit button"
Other field types behave as before
existing click and toolbar suites, unchanged and passing
The icon constant and the allowed-fields list have no dedicated test; the icon is checked by eye in the design review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Entry tags are now a field type the canvas can edit in the popup.
FieldDataType.TAGS("tags") is added, andgetFieldTypereturns it fordata_type: "tags".TAGSis allowed for modal editing,fieldIconshastags: EditIcon, andFieldTypeIconsMaphas a tags icon for the label and the cursor (the icon is the Venus tag icon, resized to 24 by 24).FieldToolbartreats tags as one whole value, like a multiple Select or Taxonomy: clicking the tags container or one chip shows the Edit button, and Edit postsOPEN_FIELD_EDIT_MODALfortagswithout the chip index.tagsrestriction, missing entry permission or a locked workflow stage still goes throughisFieldDisabled. TheOPEN_FIELD_EDIT_MODALpayload shape is unchanged.Test evidence
npm run lint: 0 errors (existing warnings only)npx vitest run --changed origin/develop_v4: 80 files, 553 tests passednpm run build: passednpx prettier --checkon the changed files: onlyFieldToolbar.tsxwarns, and it already did before this change, so it is not reformatted here to keep the diff small.Criterion to test map
getFieldTypereturnsTAGSfordata_type: "tags"getFieldType.test.ts: "should return tags if data_type is tags"tagsclick/fields/tags.test.tsx: "container click posts the whole tags field"tagswithout the indexclick/fields/tags.test.tsx: "chip click posts tags without the index"click/fields/tags.test.tsx: "restricted tags field disables the edit button"The icon constant and the allowed-fields list have no dedicated test; the icon is checked by eye in the design review.
Manual QA
None needed.
Generated by Claude Code
Generated by Claude Code