Skip to content

feat(visual-builder): edit entry tags from the canvas toolbar - #670

Merged
sairaj-cs merged 3 commits into
develop_v4from
agent/entry-tags-edit-action
Oct 28, 2026
Merged

sairaj-cs merged 3 commits into
develop_v4from
agent/entry-tags-edit-action

Conversation

@sairaj-cs

@sairaj-cs sairaj-cs commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

What changed

Entry tags are now a field type the canvas can edit in the popup.

  • FieldDataType.TAGS ("tags") is added, and getFieldType returns it for data_type: "tags".
  • TAGS is allowed for modal editing, fieldIcons has tags: EditIcon, and FieldTypeIconsMap has a tags icon for the label and the cursor (the icon is the Venus tag icon, resized to 24 by 24).
  • FieldToolbar treats tags as one whole value, like a multiple Select or Taxonomy: clicking the tags container or one chip shows the Edit button, and Edit posts OPEN_FIELD_EDIT_MODAL for tags without the chip index.
  • Disabling is unchanged: a tags restriction, missing entry permission or a locked workflow stage still goes through isFieldDisabled. The OPEN_FIELD_EDIT_MODAL payload shape is unchanged.

Test evidence

  • npm run lint: 0 errors (existing warnings only)
  • npx vitest run --changed origin/develop_v4: 80 files, 553 tests passed
  • npm run build: passed
  • npx prettier --check on the changed files: only FieldToolbar.tsx warns, and it already did before this change, so it is not reformatted here to keep the diff small.

Criterion to test map

Criterion Test
getFieldType returns TAGS for data_type: "tags" getFieldType.test.ts: "should return tags if data_type is tags"
Container click shows an enabled Edit button and posts tags click/fields/tags.test.tsx: "container click posts the whole tags field"
Chip click posts tags without the index click/fields/tags.test.tsx: "chip click posts tags without the index"
Restricted field disables Edit click/fields/tags.test.tsx: "restricted tags field disables the edit button"
Other field types behave as before existing click and toolbar suites, unchanged and passing

The icon constant and the allowed-fields list have no dedicated test; the icon is checked by eye in the design review.

Manual QA

None needed.



Generated by Claude Code


Generated by Claude Code

@snyk-io

snyk-io Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 2 0 10 ✅ Passed
🟠 High Severity 2 0 25 ✅ Passed
🟡 Medium Severity 1 0 500 ✅ Passed
🔵 Low Severity 1 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 68.72% 2597 / 3779
🔵 Statements 67.6% 2640 / 3905
🔵 Functions 66.28% 468 / 706
🔵 Branches 63.07% 1573 / 2494
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/components/FieldToolbar.tsx 70.76% 71.84% 57.14% 70.76% 67-94, 105-112, 181-182, 232-248, 312-319, 350-356, 366, 370, 423-427, 446
src/visualBuilder/components/icons/fields/index.ts 100% 100% 100% 100%
src/visualBuilder/generators/generateCustomCursor.ts 100% 80% 100% 100%
src/visualBuilder/utils/constants.ts 100% 100% 100% 100%
src/visualBuilder/utils/getFieldType.ts 96% 97.14% 100% 100% 5
Generated in workflow #951 for commit 38dcfe6 by the Vitest Coverage Report Action

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 2 0 10 ✅ Passed
🟠 High Severity 2 0 25 ✅ Passed
🟡 Medium Severity 1 0 500 ✅ Passed
🔵 Low Severity 1 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

1 similar comment
@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 2 0 10 ✅ Passed
🟠 High Severity 2 0 25 ✅ Passed
🟡 Medium Severity 1 0 500 ✅ Passed
🔵 Low Severity 1 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

@kirtesh-cstk kirtesh-cstk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sairaj-cs
sairaj-cs merged commit aba6696 into develop_v4 Oct 28, 2026
15 checks passed
@sairaj-cs
sairaj-cs deleted the agent/entry-tags-edit-action branch October 28, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants