Repository navigation
feat(field-toolbar): show the Edit button for Boolean fields - #671
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YU96SVM9VXkfjSbSeoFdZ4
faraazb-contentstack
requested review from
contentstackMridul,
hitesh-shetty-cstk,
karancs06 and
kirtesh-cstk
October 28, 2026 10:24
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
…ady cover Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YU96SUpGdU5NuSX7N5UsA5
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
SahilCs15
approved these changes
Oct 28, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Clicking an element tagged with a Boolean field now shows the Edit button in the field toolbar. The button sends
OPEN_FIELD_EDIT_MODALwith the field metadata, like Select, Taxonomy and Tags, and is disabled when the field is disabled.ALLOWED_MODAL_EDITABLE_FIELDincludesFieldDataType.BOOLEAN.fieldIconshasboolean: EditIcon, since the toolbar renders no Edit button for a type without an icon.FieldToolbarComponentis unchanged.Test evidence
npm run lint: 0 errorsnpx prettier --checkon the two changed source files: cleannpx vitest run --changed origin/develop_v4: 77 files, 526 tests passednpm run build: passesNew "Boolean field toolbar" tests in
src/visualBuilder/components/__test__/fieldToolbar.test.tsx(the click tests mock the toolbar, so they cannot see the Edit button):boolean field shows the edit buttonOPEN_FIELD_EDIT_MODALwith the field metadataedit button is disabled when the boolean field is disabledboolean field has no replace buttonNeeds manual QA
On the dev22 AI stack with the CSR test site on a
develop_v4SDK tarball: open the Edit modal from a Boolean, change and apply, cancel, a never-stored value, a Boolean inside a block card and a referenced entry, and a read-only role. The modal itself ships in Visual Editor and must be in production before this SDK is released.Generated by Claude Code
Generated by Claude Code