Skip to content

feat(field-toolbar): show the Edit button for Boolean fields - #671

Merged
faraazb-contentstack merged 2 commits into
develop_v4from
agent/boolean-edit-button
Oct 28, 2026
Merged

faraazb-contentstack merged 2 commits into
develop_v4from
agent/boolean-edit-button

Conversation

@faraazb-contentstack

@faraazb-contentstack faraazb-contentstack commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

What changed

Clicking an element tagged with a Boolean field now shows the Edit button in the field toolbar. The button sends OPEN_FIELD_EDIT_MODAL with the field metadata, like Select, Taxonomy and Tags, and is disabled when the field is disabled.

  • ALLOWED_MODAL_EDITABLE_FIELD includes FieldDataType.BOOLEAN.
  • fieldIcons has boolean: EditIcon, since the toolbar renders no Edit button for a type without an icon.
  • FieldToolbarComponent is unchanged.

Test evidence

  • npm run lint: 0 errors
  • npx prettier --check on the two changed source files: clean
  • npx vitest run --changed origin/develop_v4: 77 files, 526 tests passed
  • npm run build: passes

New "Boolean field toolbar" tests in src/visualBuilder/components/__test__/fieldToolbar.test.tsx (the click tests mock the toolbar, so they cannot see the Edit button):

Behaviour Test
A Boolean shows the Edit button boolean field shows the edit button
Edit sends OPEN_FIELD_EDIT_MODAL with the field metadata the existing Select and Taxonomy click tests (same code path)
A disabled field disables the button edit button is disabled when the boolean field is disabled
No Replace button boolean field has no replace button
Other field types keep their toolbar the existing file and custom field toolbar tests

Needs manual QA

On the dev22 AI stack with the CSR test site on a develop_v4 SDK tarball: open the Edit modal from a Boolean, change and apply, cancel, a never-stored value, a Boolean inside a block card and a referenced entry, and a read-only role. The modal itself ships in Visual Editor and must be in production before this SDK is released.



Generated by Claude Code


Generated by Claude Code

@snyk-io

snyk-io Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 2 0 10 ✅ Passed
🟠 High Severity 2 0 25 ✅ Passed
🟡 Medium Severity 1 0 500 ✅ Passed
🔵 Low Severity 1 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 68.72% 2597 / 3779
🔵 Statements 67.6% 2640 / 3905
🔵 Functions 66.28% 468 / 706
🔵 Branches 63.07% 1573 / 2494
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/components/icons/fields/index.ts 100% 100% 100% 100%
src/visualBuilder/utils/constants.ts 100% 100% 100% 100%
Generated in workflow #954 for commit 88b0ee2 by the Vitest Coverage Report Action

…ady cover

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YU96SUpGdU5NuSX7N5UsA5
@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 2 0 10 ✅ Passed
🟠 High Severity 2 0 25 ✅ Passed
🟡 Medium Severity 1 0 500 ✅ Passed
🔵 Low Severity 1 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

@faraazb-contentstack
faraazb-contentstack merged commit 28f24be into develop_v4 Oct 28, 2026
10 checks passed
@faraazb-contentstack
faraazb-contentstack deleted the agent/boolean-edit-button branch October 28, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants