Skip to content

Reject unconsumed options in explicit solve mode - #853

Merged
ocots merged 2 commits into
mainfrom
fix/explicit-solve-options
Aug 13, 2026
Merged

Reject unconsumed options in explicit solve mode#853
ocots merged 2 commits into
mainfrom
fix/explicit-solve-options

Conversation

@ocots

@ocots ocots commented Aug 13, 2026

Copy link
Copy Markdown
Member

Summary

  • Reject unconsumed keyword arguments in explicit solve mode instead of silently ignoring them.
  • Provide actionable errors for strategy-specific, ambiguous, and unknown options.
  • Clarify in the explicit-mode documentation that strategy options must be configured at construction time.
  • Add regression coverage for backend, unknown options, dispatcher validation, and bypass.

Test plan

  • Targeted explicit solve tests: 28 passed.
  • Complete solve test suite: 562 passed.
  • Full package test suite: 2,184 passed; 2 expected optional-capability tests marked broken.
  • Documentation build: blocked by existing CTLie and extension precompilation errors unrelated to this change.

Generated with Devin

Strategy-specific keywords must be configured when constructing explicit components instead of being silently ignored by solve.

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Explicit-mode component names/types and the unknown-option message were
hardcoded independently of _descriptive_families/_descriptive_action_defs,
risking drift if a family or action option changes. Derive them instead.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ocots
ocots merged commit 22e88da into main Aug 13, 2026
5 of 6 checks passed
@ocots
ocots deleted the fix/explicit-solve-options branch August 13, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant