Skip to content

renovate: run update_artifacts_lockfile as postUpgradeTasks - #4606

Draft
c4rt0 wants to merge 1 commit into
coreos:mainfrom
c4rt0:cos-3382-auto-lockfile-update
Draft

renovate: run update_artifacts_lockfile as postUpgradeTasks#4606
c4rt0 wants to merge 1 commit into
coreos:mainfrom
c4rt0:cos-3382-auto-lockfile-update

Conversation

@c4rt0

@c4rt0 c4rt0 commented Aug 7, 2026

Copy link
Copy Markdown
Member

When MintMaker bumps the OpenShift client version in ci/hermetic/artifacts.lock.yaml it only updates the download_url fields, leaving the checksum fields pointing at the old version. The hermetic build then fails because the downloaded file doesn't match the stored fingerprint. Example: PR #4524.

postUpgradeTasks is a standard Renovate feature that runs a shell command after a dependency is updated. This PR adds it to the custom.oc package rule so MintMaker calls update_artifacts_lockfile immediately after bumping the OC version, refreshing all four architecture checksums in the same PR commit.

update_artifacts_lockfile is also updated to accept the lockfile path as a command-line argument (sys.argv[1]), since MintMaker runs from the repo root and needs to pass the full path. The original no-argument behavior is preserved as a fallback.

This PR has no effect until the following are merged and deployed:

See: https://issues.redhat.com/browse/COS-3382

When Renovate bumps the openshift-client version in
ci/hermetic/artifacts.lock.yaml it only updates the download_url, leaving
stale sha256 checksums that break hermetic builds.

Configure postUpgradeTasks to run update_artifacts_lockfile after each
version bump so the checksums are refreshed in the same PR.

Also add command-line argument support to update_artifacts_lockfile so
it can be called from the repo root with the lockfile path as an argument
rather than requiring the caller to cd into ci/hermetic/ first.

Depends on KONFLUX-9132 to add update_artifacts_lockfile to the
mintmaker-renovate-image and its allowedCommands list.

Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@c4rt0
c4rt0 requested a review from joelcapitao August 7, 2026 18:01
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 26bed2b4-5db9-4416-ae84-59a58e296cf1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@c4rt0
c4rt0 removed the request for review from joelcapitao August 7, 2026 18:02
@c4rt0

c4rt0 commented Aug 7, 2026

Copy link
Copy Markdown
Member Author

/do-not-merge as this PR has no effect until the two konflux-ci PR's listed in the description merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant