feat(SidebarNav): add tree variant - #279
Closed
xidedix wants to merge 4 commits into
Closed
Conversation
…Active variant="tree" renders .sidebar-nav-tree; compact now emits the class on the nav itself, not only on a group's item list; openOnActive turns off opening a group from an active link or a matching route, inherited by nested levels
openOnActive gated the whole NavigationEnd subscription, so turning it off also dropped the route-driven closing that dropdownMode owns; it now gates the open call only
dropdownMode none now also skips opening the group under the active route on init, so it means what its name says; c-sidebar-nav passes it to declaratively built groups through NavGroupService
xidedix
changed the title
xidedix
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.