Repository navigation
Render podAnnotations with tpl so the scrape port follows http_listen_port - #700
Merged
Merged
Conversation
…_port Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
kd7lxl
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
The
podAnnotationsof every component now go throughtpl, as kd7lxl suggested in the issue, and the defaultprometheus.io/port: '8080'annotations are now'{{ .Values.config.server.http_listen_port }}'. Changing the listen port then changes the scrape port too, instead of leaving the pods annotated with 8080. With the defaults the rendered output is the same as before. The ones that use thehttp-metricsport name were already fine and aren't changed.Users can now reference other values in their own pod annotations too, which also means a literal
{{in an annotation value would get templated now.Which issue(s) this PR fixes:
Fixes #410
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX],[DEPENDENCY]