Repository navigation
Conversation
extraPorts was in values.yaml for every component but no template used it. The ports are now added to the cortex container and exposed on the component's services under their name. Closes cortexproject#409 Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #409
extraPortshas been sitting in values.yaml for every component without doing anything. I went with re-enabling it rather than removing it: the entries are plain ContainerPort specs added to the cortex container, and each one is also put on the component's service (and headless service where there is one) under its name. That covers cases like the extra alertmanager ports discussed in #420.With the default values the rendered output is unchanged. I checked it with
helm templatewith a few extra ports set on alertmanager (deployment and statefulset), distributor and nginx.I used some help from AI, please don't yell at me. Thx.