Remove the deprecated -ruler.evaluation-delay-duration limit - #7792
Open
CharlieTLe wants to merge 3 commits into
Open
Remove the deprecated -ruler.evaluation-delay-duration limit#7792CharlieTLe wants to merge 3 commits into
CharlieTLe wants to merge 3 commits into
Conversation
dosubot
Bot
added
component/rules
All eight have been past the two-minor deprecation window in v1-guarantees.md for at least three minors, and every one is flag-only with no YAML config option and no effect on behaviour, so removing them cannot change how a running cluster behaves. The only impact is that a command line still passing one now fails at startup. Split out from the deprecation removals that do touch YAML config or behaviour, so an objection to those does not hold these up. docs/blocks-storage/migrate-from-chunks-to-blocks.md stops telling readers to set -querier.ingester-streaming. That guide still references other flags removed years ago (-querier.second-store-engine, -querier.use-second-store-before-time); worth a separate look at whether it should stay at all. Signed-off-by: Charlie Le <charlie_le@apple.com>
…reaming settings Unlike the flag-only removals, both of these have a YAML config option and one of them changes behaviour, so they are split out here. -<prefix>.fifocache.size was deprecated in 1.1.0, five years and twenty-one minors ago. A cache configured only through it now starts with no capacity, because NewFifoCache no longer copies it into MaxSizeItems. -querier.ingester-metadata-streaming defaulted to true and its help text has promised since 1.18.0 that the feature would be always on. The querier now always uses the streaming metadata RPCs, so the non-streaming branches in distributor_queryable.go and the three non-streaming methods on the local Distributor interface are gone. The tests that parameterised over streaming on/off collapse accordingly. Also removes the hidden ingester_streaming YAML field, which had no reader at all - it was left behind when -querier.ingester-streaming was deprecated in 1.17.0. Because Cortex decodes config with UnmarshalStrict, that field was still silently accepted until now. Generated config docs and the JSON schema are regenerated. Signed-off-by: Charlie Le <charlie_le@apple.com>
Deprecated in 1.18.0, and its own help text has said since then that it would be removed in v1.19.0 - three minors overdue. -ruler.query-offset replaces it, and RulerQueryOffset no longer has to take the higher of the two values. Kept as its own change because it has the widest blast radius of the deprecation removals: ruler_evaluation_delay_duration is a per-tenant limit, so it can appear in the runtime config as well as on the command line. Strict decoding means a leftover override there fails every reload rather than failing startup, which pins the last good overrides and only shows up as cortex_runtime_config_last_reload_successful going to 0. The integration tests set the flag to 0 to disable the delay; the ruler query offset already defaults to 0, so dropping the flag preserves their intent. Signed-off-by: Charlie Le <charlie_le@apple.com>
CharlieTLe
force-pushed
the
release-1.22-pr-d3-remove-ruler-evaluation-delay
branch
from
August 20, 2026 01:20
4aaf71d to
e3b7c6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groundwork for v1.22.0. Refs #5922.
Important
Stacked on #7790 and #7791. Please merge those first; this branch contains their
commits, so the diff here shows all three until they land. Review the third commit only.
Deprecated in 1.18.0, and its own help text has said since then that it would be
removed in v1.19.0 — three minors overdue:
-ruler.query-offset/ruler_query_offsetreplaces it, andOverrides.RulerQueryOffset()no longer has to take the higher of the two values — it returns
RulerQueryOffsetdirectly.Kept as its own PR because it has the widest blast radius of the three removals.
ruler_evaluation_delay_durationis a per-tenant limit, so it can appear in the runtimeconfig as well as on the command line.
pkg/cortex/runtime_config.godecodes the runtimeconfig with
SetStrict(true), so a leftover override there does not crash the process.Instead it makes every runtime config reload fail, which:
cortex_runtime_config_last_reload_successfulto 0.That is considerably easier to miss than a crash. Before upgrading:
The release notes should call this out prominently.
Integration tests
Five tests in
integration/ruler_test.goset-ruler.evaluation-delay-duration: "0"todisable the delay. The ruler query offset already defaults to 0, so dropping the flag
preserves their intent.
Verification
go build ./...,go vet(including the integration build tags),make doc(generatedconfig reference and JSON schema regenerated), and
./pkg/util/validation/... ./pkg/ruler/... ./pkg/cortex/...all green.