Formally deprecate -blocks-storage.tsdb.max-exemplars - #7793
Open
CharlieTLe wants to merge 1 commit into
Open
Conversation
CharlieTLe
force-pushed
the
release-1.22-pr-f-deprecate-max-exemplars
branch
from
August 20, 2026 01:17
1d41b36 to
d93a92d
Compare
The flag's help text has called itself deprecated for a long time, but the deprecation was never announced in CHANGELOG.md, so the two-minor removal window in v1-guarantees.md never started. It is also still live code: getMaxExemplars uses it as the global fallback whenever a tenant's max_exemplars limit is 0, so removing it now would silently disable exemplars for those tenants. Start the clock properly instead. The flag keeps working, but setting it logs a warning and increments deprecated_flags_inuse_total so operators can find and migrate the usages, and the help text names v1.24.0 as the removal target. Signed-off-by: Charlie Le <charlie_le@apple.com>
CharlieTLe
force-pushed
the
release-1.22-pr-f-deprecate-max-exemplars
branch
from
August 20, 2026 01:17
d93a92d to
a29e5db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groundwork for v1.22.0. Refs #5922. Optional — happy to drop this if the maintainers would
rather not start another clock this cycle.
-blocks-storage.tsdb.max-exemplarshas called itself deprecated in its flag help for along time:
But the deprecation was never announced in
CHANGELOG.md, so the two-minor removalwindow in
v1-guarantees.mdnever actually started, and there is no signal an operator canalert on.
It is also still live code, not an overdue no-op.
Ingester.getMaxExemplarsuses it asthe global fallback whenever a tenant's
max_exemplarslimit is 0:Removing it now would silently disable exemplars for every tenant relying on that fallback.
What this does instead
Starts the clock properly. The flag keeps working exactly as before, but:
does, rather than just "use maxExemplars in limits instead";
deprecated_flags_inuse_total, so operators can find and migrate the usages — which isthe whole point of a formal deprecation.
Removal in 1.24.0, two minors from now, per
v1-guarantees.md.Verification
go build ./...,make doc(generated config reference and JSON schema regenerated), and./pkg/ingester/ ./pkg/storage/tsdb/green.