Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fhenneke
approved these changes
Oct 9, 2026
fhenneke
left a comment
fhenneke
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this update.
Left a few comments. Mostly related to phrasing which was a bit outdated in the original. Our approach was to update such phrasing whenvever we encounter it.
| Once each winning solver executes the orders for which they proposed the best bids on-chain, users receive their tokens. | ||
|
|
||
| The competition between solvers in a batch auction ensures that users (including traders, DAOs, smart contracts, and bots) always receive the best prices for their trades. | ||
| The competition between solvers in a fair combinatorial auction ensures that users (including traders, DAOs, smart contracts, and bots) always receive the best prices for their trades. |
Contributor
There was a problem hiding this comment.
Maybe something for BD to reword, as per "always receive the best prices". @cowprotocol/moodocs
Co-authored-by: Felix Henneke <felix.henneke@protonmail.com>
Co-authored-by: Felix Henneke <felix.henneke@protonmail.com>
Co-authored-by: Felix Henneke <felix.henneke@protonmail.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This part of the docs still described the prior batch auction the protocol used to run with a single winner per auction. This PR updates that to reflect the current version of combinatorial auctions the protocol uses.