Repository navigation
design-proposal(ip-address-claims): a platform that bills addresses bills claims - #126
Conversation
…ills claims The prose rewrite in 82cd418 dropped this clause from "Metering follows the claim", which left the ledger sentence reading as if IPAddress objects were the billable unit. The clause is restored, and the ledger is described as the record behind the bill. Assisted-by: LLM Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
IvanHunters
left a comment
IvanHunters
left a comment
There was a problem hiding this comment.
LGTM. This resolves the metering concern I raised on the metrics PR (address-controller#12) at the design level, and it resolves it the right way. Reframing the unit of accounting from the address to the claim, "a platform that bills addresses bills claims, as storage bills PersistentVolumeClaims," matches how the implementation actually accounts: the per-namespace claim gauge is the billable unit, and the address ledger is the record behind it. The PersistentVolumeClaim analogy is apt, and a dual-stack claim is then one billable unit rather than an undercount of two addresses, which was the other half of my concern. The paragraph stays internally consistent (claimRef says whose, the conditions say since when).
Restores a clause to Metering follows the claim in the
ip-address-claimsproposal. When the paragraph was added in e04d0eb it ended: "a platform that bills addresses bills claims". The prose rewrite in 82cd418 dropped that clause. What remained, "TheIPAddressledger is the unit of accounting", reads as ifIPAddressobjects were the billable unit, and review of cozystack/address-controller#12 read it that way.The paragraph now says that a platform bills claims, as storage bills
PersistentVolumeClaims, and that theIPAddressledger is the record behind the bill:claimRefsays whose, the conditions say since when.Before review
decisions/directory, or says below why none is needed.No record is needed. This is a wording fix that restores what the paragraph said before the prose rewrite; no decision changed.
DCO
git commit --signoff).